Re: [PATCH] PCI: Remove pci_try_set_mwi

Kalle Valo
2020-12-09T08:41:20Z

Heiner Kallweit <hkallweit1@gmail.com> writes:

> pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the
> former one is declared as __must_check. However also some callers of
> pci_set_mwi() have a comment that it's an optional feature. I don't
> think there's much sense in this separation and the use of
> __must_check. Therefore remove pci_try_set_mwi() and remove the
> __must_check attribute from pci_set_mwi().
> I don't expect either function to be used in new code anyway.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> patch applies on top of pci/misc for v5.11

> drivers/net/wireless/intersil/p54/p54pci.c | 2 +-
> .../intersil/prism54/islpci_hotplug.c | 3 +--
> .../wireless/realtek/rtl818x/rtl8180/dev.c | 2 +-

For drivers/wireless:

Acked-by: Kalle Valo <kvalo@codeaurora.org>

--