Re: [PATCH] PCI: Remove pci_try_set_mwi

Lee Jones
2020-12-09T09:23:24Z

On Wed, 09 Dec 2020, Heiner Kallweit wrote:

> pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the
> former one is declared as __must_check. However also some callers of
> pci_set_mwi() have a comment that it's an optional feature. I don't
> think there's much sense in this separation and the use of
> __must_check. Therefore remove pci_try_set_mwi() and remove the
> __must_check attribute from pci_set_mwi().
> I don't expect either function to be used in new code anyway.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> patch applies on top of pci/misc for v5.11
> ---
> Documentation/PCI/pci.rst | 5 +----
> drivers/ata/pata_cs5530.c | 2 +-
> drivers/ata/sata_mv.c | 2 +-
> drivers/dma/dw/pci.c | 2 +-
> drivers/dma/hsu/pci.c | 2 +-
> drivers/ide/cs5530.c | 2 +-

> drivers/mfd/intel-lpss-pci.c | 2 +-

Acked-by: Lee Jones <lee.jones@linaro.org>

> drivers/net/ethernet/adaptec/starfire.c | 2 +-
> drivers/net/ethernet/alacritech/slicoss.c | 2 +-
> drivers/net/ethernet/dec/tulip/tulip_core.c | 5 +----
> drivers/net/ethernet/sun/cassini.c | 4 ++--
> drivers/net/wireless/intersil/p54/p54pci.c | 2 +-
> .../intersil/prism54/islpci_hotplug.c | 3 +--
> .../wireless/realtek/rtl818x/rtl8180/dev.c | 2 +-
> drivers/pci/pci.c | 19 -------------------
> drivers/scsi/3w-9xxx.c | 4 ++--
> drivers/scsi/3w-sas.c | 4 ++--
> drivers/scsi/csiostor/csio_init.c | 2 +-
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> drivers/scsi/qla2xxx/qla_init.c | 8 ++++----
> drivers/scsi/qla2xxx/qla_mr.c | 2 +-
> drivers/tty/serial/8250/8250_lpss.c | 2 +-
> drivers/usb/chipidea/ci_hdrc_pci.c | 2 +-
> drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +-
> drivers/usb/gadget/udc/net2280.c | 2 +-
> drivers/usb/gadget/udc/pch_udc.c | 2 +-
> include/linux/pci.h | 5 ++---
> 27 files changed, 33 insertions(+), 60 deletions(-)

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog