From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12AEEC433C1 for ; Mon, 22 Mar 2021 06:05:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9BC161966 for ; Mon, 22 Mar 2021 06:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229613AbhCVGFL (ORCPT ); Mon, 22 Mar 2021 02:05:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:51056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229973AbhCVGEy (ORCPT ); Mon, 22 Mar 2021 02:04:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2000D6192E; Mon, 22 Mar 2021 06:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616393094; bh=XHSJVFYLkfSrTabMwU77kIGMegQzpz9eSl2b5yGtDdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a/u+Yi1TNEVNGGo/bUsxAwLNr2Yb0hy6GggXTIkEG+1Q65pUBVldkBr/Fq/UTodTL /at0FtykXpSzDXC9gQ38IGNab8/Q9PP92D7nFioCF/pMZjs6P89c0AAypREj75VsqG +i3GWNlSjK8+bCn4o11IOoDG8LlcBVvvllHyYvAgCvJbiIWnzj+YZKUK9md5I/BNd3 qYc/K6aGS/BfP5JPoIKF95gdKxyWpBM0ryJxYWrobpfm1LxdGQ5H13Zpm/q0XuwQeh BBZBQIMzSYMbRspt72tW+Yf95bSVJnZn6uETAcYZTf2GJm1j//l6gOwq6BtVYX7WmZ IuEwX2jSJgnog== Date: Mon, 22 Mar 2021 11:34:49 +0530 From: Vinod Koul To: Sanjay R Mehta Cc: gregkh@linuxfoundation.org, dan.j.williams@intel.com, Thomas.Lendacky@amd.com, Shyam-sundar.S-k@amd.com, Nehal-bakulchandra.Shah@amd.com, robh@kernel.org, mchehab+samsung@kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH v7 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA Message-ID: References: <1602833947-82021-1-git-send-email-Sanju.Mehta@amd.com> <1602833947-82021-2-git-send-email-Sanju.Mehta@amd.com> <20201118115545.GQ50232@vkoul-mobl> <5605dae6-3dde-17f9-35c8-7973106b9bea@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5605dae6-3dde-17f9-35c8-7973106b9bea@amd.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 18-03-21, 16:16, Sanjay R Mehta wrote: > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > > > > why do you need sched.h here? > > > >> + > >> +#include "ptdma.h" > >> + > >> +/* Ever-increasing value to produce unique unit numbers */ > >> +static atomic_t pt_ordinal; > > > > What is the need of that? > > > [please wrap your emails within 80 chars] > The "pt_ordinal" is incremented for each DMA instances and its number > is used only to assign device name for each instances. This same > device name is passed as a string parameter in many places in code > like while using request_irq(), dma_pool_create() and in debugfs. Why do you need that, why not use device name which is unique..? > Also, I have implemented all of the comments for this patch except > this. if this is fine, will send the next version for review. Am not sure I remember all the comments I gave, it has been _quite_ a while since the feedback was provided. In order to have effective review it would be great to revert back on a reasonable timeline and discuss... Thanks -- ~Vinod