Re: [PATCH 00/16] CSI2RX support on J721E

Vinod Koul
2021-03-31T13:07:13Z

On 31-03-21, 17:10, Pratyush Yadav wrote:
> On 31/03/21 03:03PM, Vinod Koul wrote:
> > On 30-03-21, 23:03, Pratyush Yadav wrote:
> > > Hi,
> > >
> > > This series adds support for CSI2 capture on J721E. It includes some
> > > fixes to the Cadence CSI2RX driver, adds Rx support to Cadence DPHY
> > > driver, and finally adds the TI CSI2RX wrapper driver.
> > >
> > > Tested on TI's J721E with OV5640 sensor.
> > >
> > > Paul Kocialkowski (1):
> > > phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes
> > >
> > > Pratyush Yadav (15):
> > > phy: cdns-dphy: Prepare for Rx support
> > > phy: cdns-dphy: Allow setting mode
> > > phy: cdns-dphy: Add Rx support
> > > media: cadence: csi2rx: Add external DPHY support
> > > media: cadence: csi2rx: Soft reset the streams before starting capture
> > > media: cadence: csi2rx: Set the STOP bit when stopping a stream
> > > media: cadence: csi2rx: Fix stream data configuration
> > > media: cadence: csi2rx: Turn subdev power on before starting stream
> > > media: cadence: csi2rx: Add wrappers for subdev calls
> > > dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX
> > > dt-bindings: media: Add DT bindings for TI CSI2RX driver
> > > media: ti-vpe: csi2rx: Add CSI2RX support
> > > dt-bindings: phy: Convert Cadence DPHY binding to YAML
> > > dt-bindings: phy: cdns,dphy: make clocks optional
> > > dt-bindings: phy: cdns,dphy: add power-domains property
> >
> > Is there any dependency between patches to various subsystems, if not
> > please do consider sending a series per subsystem...
>
> Without patch 1, patch 5 and later won't build. Without patch 11, patch
> 13 will not work.

Cover letter is a good place to mention this! And what do you mean by
not working, do we have compile time dependencies? I agree that for
everything to work all the pieces need to land

--
~Vinod