Re: [PATCH 03/16] phy: cdns-dphy: Allow setting mode

Pratyush Yadav
2021-04-06T18:22:59Z

On 02/04/21 01:38PM, Laurent Pinchart wrote:
> Hi Pratyush,
>
> Thank you for the patch.
>
> On Tue, Mar 30, 2021 at 11:03:35PM +0530, Pratyush Yadav wrote:
> > Allow callers to set the PHY mode. The main mode should always be
> > PHY_MODE_MIPI_DPHY but the submode can either be
> > PHY_MIPI_DPHY_SUBMODE_RX or PHY_MIPI_DPHY_SUBMODE_TX. Update the ops
> > based on the requested submode.
>
> Isn't a given DPHY instance always meant to work in one particular mode
> ? I can't really imagine a single instance of this IP core being
> integrated in a way that it can be used in either RX or TX mode. It
> seems better to select the mode through DT, by describing if the DPHY is
> an RX or TX (possibly through different compatible strings).

I'm not sure if the DPHY can work in both RX and TX mode but the
documentation for Cadence DPHY on J721E does include both RX and TX
related registers. Also, take a look at [0] which says that the
Allwinner A31 DPHY can work in both RX and TX mode. So apparently there
are some DPHYs like that in the wild.

[0] https://lore.kernel.org/linux-arm-kernel/20201023174546.504028-3-paul.kocialkowski@bootlin.com/

>
> > Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> > ---
> > drivers/phy/cadence/cdns-dphy.c | 30 ++++++++++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
> >
> > diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dphy.c
> > index 8656f2102a91..7d5f7b333893 100644
> > --- a/drivers/phy/cadence/cdns-dphy.c
> > +++ b/drivers/phy/cadence/cdns-dphy.c
> > @@ -365,11 +365,41 @@ static int cdns_dphy_configure(struct phy *phy, union phy_configure_opts *opts)
> > return 0;
> > }
> >
> > +static int cdns_dphy_set_mode(struct phy *phy, enum phy_mode mode, int submode)
> > +{
> > + struct cdns_dphy *dphy = phy_get_drvdata(phy);
> > + const struct cdns_dphy_driver_data *ddata;
> > +
> > + ddata = of_device_get_match_data(dphy->dev);
> > + if (!ddata)
> > + return -EINVAL;
> > +
> > + if (mode != PHY_MODE_MIPI_DPHY)
> > + return -EINVAL;
> > +
> > + if (submode == PHY_MIPI_DPHY_SUBMODE_TX) {
> > + if (!ddata->tx)
> > + return -EOPNOTSUPP;
> > +
> > + dphy->ops = ddata->tx;
> > + } else if (submode == PHY_MIPI_DPHY_SUBMODE_RX) {
> > + if (!ddata->rx)
> > + return -EOPNOTSUPP;
> > +
> > + dphy->ops = ddata->rx;
> > + } else {
> > + return -EOPNOTSUPP;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > static const struct phy_ops cdns_dphy_ops = {
> > .configure = cdns_dphy_configure,
> > .validate = cdns_dphy_validate,
> > .power_on = cdns_dphy_power_on,
> > .power_off = cdns_dphy_power_off,
> > + .set_mode = cdns_dphy_set_mode,
> > };
> >
> > static int cdns_dphy_probe(struct platform_device *pdev)
>
> --
> Regards,
>
> Laurent Pinchart

--
Regards,
Pratyush Yadav
Texas Instruments Inc.