From: Vinod Koul <vkoul@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: remove MSIX masking for interrupt handlers
Date: Fri, 23 Apr 2021 23:09:11 +0530 [thread overview]
Message-ID: <YIMGP+/2hrUUWRsI@vkoul-mobl.Dlink> (raw)
In-Reply-To: <161894523436.3210025.1834640110556139277.stgit@djiang5-desk3.ch.intel.com>
On 20-04-21, 12:00, Dave Jiang wrote:
> Remove interrupt masking and just let the hard irq handler keep
> firing for new events. This is less of a performance impact vs
> the MMIO readback inside the pci_msi_{mask,unmas}_irq(). Especially
> with a loaded system those flushes can be stuck behind large amounts
> of MMIO writes to flush. When guest kernel is running on top of VFIO
> mdev, mask/unmask causes a vmexit each time and is not desirable.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-04-23 17:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 19:00 [PATCH] dmaengine: idxd: remove MSIX masking for interrupt handlers Dave Jiang
2021-04-23 17:39 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIMGP+/2hrUUWRsI@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox