From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAEB8C4707F for ; Sun, 23 May 2021 00:20:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC5C861205 for ; Sun, 23 May 2021 00:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231479AbhEWAVf (ORCPT ); Sat, 22 May 2021 20:21:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231446AbhEWAVf (ORCPT ); Sat, 22 May 2021 20:21:35 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8583FC061574; Sat, 22 May 2021 17:20:09 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B0D242A8; Sun, 23 May 2021 02:20:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1621729205; bh=F5R+Ym46eRNyJ7nYF6pjtVqD2w5HTuZXq2ESBHDvgbY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BJQZLoI0TPvuLPj02Y/KKVtYeXwss7o7ut5/rQMjneaP260VmoEU5FWWw1XBNgzQD aY0uSXB/Y/QW3z3bT9Dpc+schxnIBy0ciwRD/2lb6SG+YBNn6Lj1fKSpQ7rzjeyUil e9RGr8F2ZSuAFxN+TOVMMdbsx/U25xvUPma89hj0= Date: Sun, 23 May 2021 03:20:03 +0300 From: Laurent Pinchart To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Stefan Roese , Vinod Koul , dmaengine@vger.kernel.org, Sinan Kaya , Green Wan , Hyun Kwon , Tejas Upadhyay , Michal Simek , kernel test robot Subject: Re: [PATCH 4/4] DMA: XILINX_ZYNQMP_DPDMA depends on HAS_IOMEM Message-ID: References: <20210522021313.16405-1-rdunlap@infradead.org> <20210522021313.16405-5-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210522021313.16405-5-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Randy, Thank you for the patch. On Fri, May 21, 2021 at 07:13:13PM -0700, Randy Dunlap wrote: > When CONFIG_HAS_IOMEM is not set/enabled, most iomap() family > functions [including ioremap(), devm_ioremap(), etc.] are not > available. > Drivers that use these functions should depend on HAS_IOMEM so that > they do not cause build errors. > > Cures this build error: > s390-linux-ld: drivers/dma/xilinx/xilinx_dpdma.o: in function `xilinx_dpdma_probe': > xilinx_dpdma.c:(.text+0x336a): undefined reference to `devm_platform_ioremap_resource' I've previously posted https://lore.kernel.org/dmaengine/20210520152420.23986-2-laurent.pinchart@ideasonboard.com/T/#u which fixes the same issue (plus an additional one). > Fixes: 7cbb0c63de3fc ("dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Vinod Koul > CC: dmaengine@vger.kernel.org > Cc: Hyun Kwon > Cc: Tejas Upadhyay > Cc: Michal Simek > Cc: Laurent Pinchart > --- > drivers/dma/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20210521.orig/drivers/dma/Kconfig > +++ linux-next-20210521/drivers/dma/Kconfig > @@ -702,6 +702,7 @@ config XILINX_ZYNQMP_DMA > > config XILINX_ZYNQMP_DPDMA > tristate "Xilinx DPDMA Engine" > + depends on HAS_IOMEM > select DMA_ENGINE > select DMA_VIRTUAL_CHANNELS > help -- Regards, Laurent Pinchart