From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8B4C4707A for ; Sun, 23 May 2021 18:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08EA9611CE for ; Sun, 23 May 2021 18:53:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231857AbhEWSyq (ORCPT ); Sun, 23 May 2021 14:54:46 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:51042 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231853AbhEWSyp (ORCPT ); Sun, 23 May 2021 14:54:45 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 07C1C2A8; Sun, 23 May 2021 20:53:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1621795997; bh=0MbZwRbBUjdf9JuXa/VR/8NC9VAmYtB+9nqLUnykiFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mW9zZyM3nNCcVNRy7hbSX4jvSOeAe64ygruErCf+u5VEX2Vr5Igz8r8BaOXaf8iU+ Zwmu/tScyWB3yAhVxeDmOcfElnoiUJWqgt8M0tMswSZnWb0ripAxpIQtBo8zacJhNf LUDL+GJVi3MjGoYKbW2ESFIarPSE0q1FGxyjKkIM= Date: Sun, 23 May 2021 21:53:13 +0300 From: Laurent Pinchart To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Stefan Roese , Vinod Koul , dmaengine@vger.kernel.org, Sinan Kaya , Green Wan , Hyun Kwon , Tejas Upadhyay , Michal Simek , kernel test robot Subject: Re: [PATCH 4/4] DMA: XILINX_ZYNQMP_DPDMA depends on HAS_IOMEM Message-ID: References: <20210522021313.16405-1-rdunlap@infradead.org> <20210522021313.16405-5-rdunlap@infradead.org> <5cb3b313-cd96-d687-2916-0d4af8e5e675@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5cb3b313-cd96-d687-2916-0d4af8e5e675@infradead.org> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Randy, On Sat, May 22, 2021 at 06:07:01PM -0700, Randy Dunlap wrote: > On 5/22/21 5:20 PM, Laurent Pinchart wrote: > > On Fri, May 21, 2021 at 07:13:13PM -0700, Randy Dunlap wrote: > >> When CONFIG_HAS_IOMEM is not set/enabled, most iomap() family > >> functions [including ioremap(), devm_ioremap(), etc.] are not > >> available. > >> Drivers that use these functions should depend on HAS_IOMEM so that > >> they do not cause build errors. > >> > >> Cures this build error: > >> s390-linux-ld: drivers/dma/xilinx/xilinx_dpdma.o: in function `xilinx_dpdma_probe': > >> xilinx_dpdma.c:(.text+0x336a): undefined reference to `devm_platform_ioremap_resource' > > > > I've previously posted > > https://lore.kernel.org/dmaengine/20210520152420.23986-2-laurent.pinchart@ideasonboard.com/T/#u > > which fixes the same issue (plus an additional one). > > Hi Laurent, > > I didn't add a dependency on OF because OF header files _mostly_ > have stubs so that they work when OF is enabled or disabled. > > I did find a problem in where it could end up > without having a stub. I will post a patch for that soon. > I'm currently doing lots of randconfig builds on it. I'm fine with eithe approach, but the patch you've posted to address the of_address.h issue has an issue itself. If Vinod would prefer merging this patch instead of mine, Reviewed-by: Laurent Pinchart > >> Fixes: 7cbb0c63de3fc ("dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine driver") > >> Signed-off-by: Randy Dunlap > >> Reported-by: kernel test robot > >> Cc: Vinod Koul > >> CC: dmaengine@vger.kernel.org > >> Cc: Hyun Kwon > >> Cc: Tejas Upadhyay > >> Cc: Michal Simek > >> Cc: Laurent Pinchart > >> --- > >> drivers/dma/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> --- linux-next-20210521.orig/drivers/dma/Kconfig > >> +++ linux-next-20210521/drivers/dma/Kconfig > >> @@ -702,6 +702,7 @@ config XILINX_ZYNQMP_DMA > >> > >> config XILINX_ZYNQMP_DPDMA > >> tristate "Xilinx DPDMA Engine" > >> + depends on HAS_IOMEM > >> select DMA_ENGINE > >> select DMA_VIRTUAL_CHANNELS > >> help -- Regards, Laurent Pinchart