From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C41C4708F for ; Mon, 31 May 2021 04:00:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4759261108 for ; Mon, 31 May 2021 04:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229471AbhEaECU (ORCPT ); Mon, 31 May 2021 00:02:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:55990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229466AbhEaECU (ORCPT ); Mon, 31 May 2021 00:02:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F407F60FEB; Mon, 31 May 2021 04:00:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622433640; bh=XaoLCwYWhSf9Bigq0YTehKp6euZPqSNLDQH634g/3R0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n4E7SqRYBMwWHQzLSJnC6pk0vz4wxnBh8UmvS3xZS72plgWsy98jkGnhlZFpNu+Yy lWqL+H8aNp0M344QZFkc95sXMLH3QNrCu34riaXhi/3UBr49/39COWZQBPyCSCqcrc tQborjyZN4L4/lZskeHeTfrAU4IIrHozFwEyjk3fbpjy0lgWVC3a4mBg3h/j9YSLkU YmAMP6P6iSm7S5IFPswJHZ3gvgrYRkt1wFuebjLs6SKoEbcKzN8tokgDPn5jmr05A+ jJnLZxW+iiSitmQRYHBu/cM8PhYrn16hJJ4Ulr0uoELiIUMoI315ZJlbXKFDtfNaqx VpymCo14Kmn0g== Date: Mon, 31 May 2021 09:30:37 +0530 From: Vinod Koul To: Yu Kuai Cc: mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, michal.simek@xilinx.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, yi.zhang@huawei.com Subject: Re: [PATCH 2/3] dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe() Message-ID: References: <20210517081826.1564698-1-yukuai3@huawei.com> <20210517081826.1564698-3-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210517081826.1564698-3-yukuai3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 17-05-21, 16:18, Yu Kuai wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported-by: Hulk Robot > Signed-off-by: Yu Kuai > --- > drivers/dma/sh/usb-dmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c > index 8f7ceb698226..2a6c8fd8854e 100644 > --- a/drivers/dma/sh/usb-dmac.c > +++ b/drivers/dma/sh/usb-dmac.c > @@ -796,7 +796,7 @@ static int usb_dmac_probe(struct platform_device *pdev) > > /* Enable runtime PM and initialize the device. */ > pm_runtime_enable(&pdev->dev); > - ret = pm_runtime_get_sync(&pdev->dev); > + ret = pm_runtime_resume_and_get(&pdev->dev); This does not seem to fix anything.. the below goto goes and disables the runtime_pm for this device and thus there wont be any leak > if (ret < 0) { > dev_err(&pdev->dev, "runtime PM get sync failed (%d)\n", ret); > goto error_pm; > -- > 2.25.4 -- ~Vinod