From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1631C4708F for ; Mon, 31 May 2021 04:16:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A80936120E for ; Mon, 31 May 2021 04:16:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229475AbhEaEST (ORCPT ); Mon, 31 May 2021 00:18:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:59168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhEaEST (ORCPT ); Mon, 31 May 2021 00:18:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 16A4660FF0; Mon, 31 May 2021 04:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622434599; bh=WrrNcXLSHGAxtkDaYh0sooXVPLQWlfDXREfK1i3H/5E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZSNt6RNUzsFj9QqGharZZ/5OVOErMq24NUVJUMA3vcK9ZQIk2vk0cRcPTSD5Kz5hq LqMKAcCXBv2DaYPPefCkKDSfEuqesQUAwmHpqZT0fzecNe1OlS9kBfWSjftgezJL7R X0hJwwvahOCLHA2euDqqvAdkNGO1Cg/QvEUXpU5fLNyfg5zgZBry5snamtdexI5qCM att6IndNwPQgS5b/rTtayW+ISR9zx3HSgSx7vDdL052nfx/Z+G7mrdVvdXKZCzzW98 Yw6QeGZcNc4BLYOJ+anmQk3aEV7TDphNwmE2d5HALkwgJgjgxZWOl/xGNXw1JIsabD usLUFzXJfDAwQ== Date: Mon, 31 May 2021 09:46:36 +0530 From: Vinod Koul To: Zou Wei Cc: orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next] dmaengine: fix PM reference leak Message-ID: References: <1621601902-33697-1-git-send-email-zou_wei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1621601902-33697-1-git-send-email-zou_wei@huawei.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 21-05-21, 20:58, Zou Wei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. Please rebase and submit per driver.. I have already applied few fixes for this and rejected few -- ~Vinod