Re: [PATCH v9 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA

Sanjay R Mehta
2021-06-16T12:53:26Z

On 6/16/2021 5:53 PM, Greg KH wrote:
> [CAUTION: External Email]
>
> On Wed, Jun 16, 2021 at 05:30:49PM +0530, Sanjay R Mehta wrote:
>> The pt_device is allocated and initialized in the PCI probe function and
>> then we just get the "dev" from the "pci_dev" object and save it in
>> "pt->dev" as shown in below snippet.
>>
>>
>> static int pt_pci_probe(struct pci_dev *pdev, const struct
>> pci_device_id *id)
>> {
>> struct pt_device *pt;
>> struct pt_msix *pt_msix;
>> struct device *dev = &pdev->dev;
>
> So "dev" is a parent here, or something else?
>
> If it is the parent, please call it such otherwise it is confusing.
>
> If you are creating child devices, what bus do they belong to?
>
> Can you fix up this series and resend it so that we can review it again?
>

Hi Greg,

Yes, "dev" is the parent here and there are no child devices created.

My apologies for not calling it rightly.

Sure, I will fix up this series addressing all the comments and will
send the next version.

Thanks,
-Sanjay