From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 118A8C4743C for ; Wed, 23 Jun 2021 12:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC27460FDC for ; Wed, 23 Jun 2021 12:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230251AbhFWNBw (ORCPT ); Wed, 23 Jun 2021 09:01:52 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:38614 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbhFWNBw (ORCPT ); Wed, 23 Jun 2021 09:01:52 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A29909AA; Wed, 23 Jun 2021 14:59:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624453173; bh=WRNQ43bka2fHx73Bt1Dxbd2nJ/Sp0ZOKsmWYcvwxIzs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sj1k4TSCKTPhIjLEc3HXCo5YNYNinTs1CsSBST/JDrTuGPn00iYNpxQs71eR1VDad PN6xuSUmux7cVbxR//zRraRQ9SVrfbRFcS1F1idRvX8zF5hVISv1FnwUGndrBWT/4O jhjaPEKgO7xMQhxWqPprjyWWD8Nr6OLRYWMXEYIQ= Date: Wed, 23 Jun 2021 15:59:04 +0300 From: Laurent Pinchart To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Hyun Kwon , Vinod Koul , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1] Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Wed, Jun 23, 2021 at 01:07:38PM +0200, Michal Simek wrote: > Use proper spacing for array calculation. Issue is reported by > checkpatch.pl --strict. > > Signed-off-by: Michal Simek > --- > > drivers/dma/xilinx/xilinx_dpdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c > index 0b67083c95d0..b280a53e8570 100644 > --- a/drivers/dma/xilinx/xilinx_dpdma.c > +++ b/drivers/dma/xilinx/xilinx_dpdma.c > @@ -531,7 +531,7 @@ static void xilinx_dpdma_sw_desc_set_dma_addrs(struct xilinx_dpdma_device *xdev, > for (i = 1; i < num_src_addr; i++) { > u32 *addr = &hw_desc->src_addr2; > > - addr[i-1] = lower_32_bits(dma_addr[i]); > + addr[i - 1] = lower_32_bits(dma_addr[i]); I don't mind either way. Reviewed-by: Laurent Pinchart > > if (xdev->ext_addr) { > u32 *addr_ext = &hw_desc->addr_ext_23; -- Regards, Laurent Pinchart