From: Vinod Koul <vkoul@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Ziye Yang <ziye.yang@intel.com>, dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmanegine: idxd: fix resource free ordering on driver removal
Date: Mon, 25 Oct 2021 11:51:33 +0530 [thread overview]
Message-ID: <YXZM7UB4y857Crpy@matsya> (raw)
In-Reply-To: <163225535868.4152687.9318737776682088722.stgit@djiang5-desk3.ch.intel.com>
On 21-09-21, 13:15, Dave Jiang wrote:
> Fault triggers on ioread32() when pci driver unbind is envoked. The
> placement of idxd sub-driver removal causes the probing of the device mmio
> region after the mmio mapping being torn down. The driver needs the
> sub-drivers to be unbound but not release the idxd context until all
> shutdown activities has been done. Move the sub-driver unregistering up
> before the remove() calls shutdown(). But take a device ref on the
> idxd->conf_dev so that the memory does not get freed in ->release(). When
> all cleanup activities has been done, release the ref to allow the idxd
> memory to be freed.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-10-25 6:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 20:15 [PATCH] dmanegine: idxd: fix resource free ordering on driver removal Dave Jiang
2021-10-25 6:21 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXZM7UB4y857Crpy@matsya \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=ziye.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox