* [PATCH] dmaengine: idxd: reconfig device after device reset command
@ 2021-09-02 0:18 Dave Jiang
2021-10-25 6:41 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2021-09-02 0:18 UTC (permalink / raw)
To: vkoul; +Cc: Sanjay Kumar, dmaengine
Device reset clears the MSIXPERM table and the device registers. Re-program
the MSIXPERM table and re-enable the error interrupts post reset.
Fixes: 745e92a6d816 ("dmaengine: idxd: idxd: move remove() bits for idxd 'struct device' to device.c")
Reported-by: Sanjay Kumar <sanjay.k.kumar@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
drivers/dma/idxd/device.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 83a5ff2ecf2a..39acb018664f 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -584,6 +584,8 @@ void idxd_device_reset(struct idxd_device *idxd)
spin_lock(&idxd->dev_lock);
idxd_device_clear_state(idxd);
idxd->state = IDXD_DEV_DISABLED;
+ idxd_unmask_error_interrupts(idxd);
+ idxd_msix_perm_setup(idxd);
spin_unlock(&idxd->dev_lock);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: idxd: reconfig device after device reset command
2021-09-02 0:18 [PATCH] dmaengine: idxd: reconfig device after device reset command Dave Jiang
@ 2021-10-25 6:41 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-10-25 6:41 UTC (permalink / raw)
To: Dave Jiang; +Cc: Sanjay Kumar, dmaengine
On 01-09-21, 17:18, Dave Jiang wrote:
> Device reset clears the MSIXPERM table and the device registers. Re-program
> the MSIXPERM table and re-enable the error interrupts post reset.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-25 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-02 0:18 [PATCH] dmaengine: idxd: reconfig device after device reset command Dave Jiang
2021-10-25 6:41 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).