From: Vinod Koul <vkoul@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Stefan Roese <sr@denx.de>, Michal Simek <michal.simek@xilinx.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH 1/3] dmaengine: altera-msgdma: Correctly handle descriptor callbacks
Date: Thu, 28 Oct 2021 22:54:06 +0530 [thread overview]
Message-ID: <YXrctnB/4F2hzBHG@matsya> (raw)
In-Reply-To: <20211025075428.2094-1-lars@metafoo.de>
On 25-10-21, 09:54, Lars-Peter Clausen wrote:
> DMA clients can provide one of two types of callbacks. For this reason
> dmaengine drivers should not directly invoke `callback`, but always use
> dmaengine_desc_callback_invoke(). This makes sure that both types of
> callbacks are handled correctly.
>
> The altera-msgdma driver currently doesn't do this and only handles the
> `callback` type callback. If the client used the `callback_result` type
> callback it will not be called.
>
> Fix this by switching to `dmaengine_desc_callback_valid()` and
> `dmaengine_desc_callback_invoke()`.
Applied all, thanks
--
~Vinod
prev parent reply other threads:[~2021-10-28 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 7:54 [PATCH 1/3] dmaengine: altera-msgdma: Correctly handle descriptor callbacks Lars-Peter Clausen
2021-10-25 7:54 ` [PATCH 2/3] dmaengine: xilinx_dma: Correctly handle cyclic " Lars-Peter Clausen
2021-10-25 7:54 ` [PATCH 3/3] dmaengine: zynqmp_dma: Correctly handle " Lars-Peter Clausen
2021-10-28 17:24 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXrctnB/4F2hzBHG@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=michal.simek@xilinx.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox