From: Vinod Koul <vkoul@kernel.org>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: ludovic.desroches@microchip.com, richard.genoud@gmail.com,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
mripard@kernel.org, linux-arm-kernel@lists.infradead.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 08/13] dmaengine: at_xdmac: Move the free desc to the tail of the desc list
Date: Mon, 13 Dec 2021 13:37:25 +0530 [thread overview]
Message-ID: <Ybb/PV5M1Gi59s7I@matsya> (raw)
In-Reply-To: <20211125090028.786832-9-tudor.ambarus@microchip.com>
On 25-11-21, 11:00, Tudor Ambarus wrote:
> So that we don't use the same desc over and over again.
Please use full para in the changelog and not a continuation of the
patch title!
and why is wrong with using same desc over and over? Any benefits of not
doing so?
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/dma/at_xdmac.c | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 2cc9af222681..8804a86a9bcc 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -729,7 +729,8 @@ at_xdmac_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
> if (!desc) {
> dev_err(chan2dev(chan), "can't get descriptor\n");
> if (first)
> - list_splice_init(&first->descs_list, &atchan->free_descs_list);
> + list_splice_tail_init(&first->descs_list,
> + &atchan->free_descs_list);
> goto spin_unlock;
> }
>
> @@ -817,7 +818,8 @@ at_xdmac_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf_addr,
> if (!desc) {
> dev_err(chan2dev(chan), "can't get descriptor\n");
> if (first)
> - list_splice_init(&first->descs_list, &atchan->free_descs_list);
> + list_splice_tail_init(&first->descs_list,
> + &atchan->free_descs_list);
> spin_unlock_irqrestore(&atchan->lock, irqflags);
> return NULL;
> }
> @@ -1051,8 +1053,8 @@ at_xdmac_prep_interleaved(struct dma_chan *chan,
> src_addr, dst_addr,
> xt, chunk);
> if (!desc) {
> - list_splice_init(&first->descs_list,
> - &atchan->free_descs_list);
> + list_splice_tail_init(&first->descs_list,
> + &atchan->free_descs_list);
> return NULL;
> }
>
> @@ -1132,7 +1134,8 @@ at_xdmac_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
> if (!desc) {
> dev_err(chan2dev(chan), "can't get descriptor\n");
> if (first)
> - list_splice_init(&first->descs_list, &atchan->free_descs_list);
> + list_splice_tail_init(&first->descs_list,
> + &atchan->free_descs_list);
> return NULL;
> }
>
> @@ -1308,8 +1311,8 @@ at_xdmac_prep_dma_memset_sg(struct dma_chan *chan, struct scatterlist *sgl,
> sg_dma_len(sg),
> value);
> if (!desc && first)
> - list_splice_init(&first->descs_list,
> - &atchan->free_descs_list);
> + list_splice_tail_init(&first->descs_list,
> + &atchan->free_descs_list);
>
> if (!first)
> first = desc;
> @@ -1701,7 +1704,8 @@ static void at_xdmac_tasklet(struct tasklet_struct *t)
>
> spin_lock_irq(&atchan->lock);
> /* Move the xfer descriptors into the free descriptors list. */
> - list_splice_init(&desc->descs_list, &atchan->free_descs_list);
> + list_splice_tail_init(&desc->descs_list,
> + &atchan->free_descs_list);
> at_xdmac_advance_work(atchan);
> spin_unlock_irq(&atchan->lock);
> }
> @@ -1850,7 +1854,8 @@ static int at_xdmac_device_terminate_all(struct dma_chan *chan)
> /* Cancel all pending transfers. */
> list_for_each_entry_safe(desc, _desc, &atchan->xfers_list, xfer_node) {
> list_del(&desc->xfer_node);
> - list_splice_init(&desc->descs_list, &atchan->free_descs_list);
> + list_splice_tail_init(&desc->descs_list,
> + &atchan->free_descs_list);
> }
>
> clear_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
> --
> 2.25.1
--
~Vinod
next prev parent reply other threads:[~2021-12-13 8:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 9:00 [PATCH v2 00/13] dmaengine: at_xdmac: Various fixes Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 01/13] dmaengine: at_xdmac: Don't start transactions at tx_submit level Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 02/13] tty: serial: atmel: Check return code of dmaengine_submit() Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 03/13] tty: serial: atmel: Call dma_async_issue_pending() Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 04/13] dmaengine: at_xdmac: Start transfer for cyclic channels in issue_pending Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 05/13] dmaengine: at_xdmac: Print debug message after realeasing the lock Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 06/13] dmaengine: at_xdmac: Fix concurrency over chan's completed_cookie Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 07/13] dmaengine: at_xdmac: Fix race for the tx desc callback Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 08/13] dmaengine: at_xdmac: Move the free desc to the tail of the desc list Tudor Ambarus
2021-12-13 8:07 ` Vinod Koul [this message]
2021-12-13 8:51 ` Tudor.Ambarus
2021-12-13 8:59 ` Vinod Koul
2021-12-13 9:00 ` Vinod Koul
2021-12-13 9:22 ` Tudor.Ambarus
2021-12-13 9:27 ` Tudor.Ambarus
2021-11-25 9:00 ` [PATCH v2 09/13] dmaengine: at_xdmac: Fix concurrency over xfers_list Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 10/13] dmaengine: at_xdmac: Remove a level of indentation in at_xdmac_advance_work() Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 11/13] dmaengine: at_xdmac: Fix lld view setting Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 12/13] dmaengine: at_xdmac: Fix at_xdmac_lld struct definition Tudor Ambarus
2021-11-25 9:00 ` [PATCH v2 13/13] dmaengine: at_xdmac: Fix race over irq_status Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybb/PV5M1Gi59s7I@matsya \
--to=vkoul@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=richard.genoud@gmail.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox