From: Vinod Koul <vkoul@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Ming Li <ming4.li@intel.com>, dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: fix missed completion on abort path
Date: Mon, 13 Dec 2021 11:10:48 +0530 [thread overview]
Message-ID: <Ybbc4GgoWegrJ4Lh@matsya> (raw)
In-Reply-To: <163898288714.443911.16084982766671976640.stgit@djiang5-desk3.ch.intel.com>
On 08-12-21, 10:01, Dave Jiang wrote:
> Ming reported that with the abort path of the descriptor submission, there
> can be a window where a completed descriptor can be missed to be completed
> by the irq completion thread:
>
> CPU A CPU B
> Submit (successful)
>
> Submit (fail)
> irq_process_work_list() // empty
>
> llist_abort_desc()
> // remove all descs from pending list
>
> irq_process_pending_llist() // empty
> exit idxd_wq_thread() with no processing
>
> Add opportunistic descriptor completion in the abort path in order to
> remove the missed completion.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-12-13 5:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 17:01 [PATCH] dmaengine: idxd: fix missed completion on abort path Dave Jiang
2021-12-13 5:40 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybbc4GgoWegrJ4Lh@matsya \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=ming4.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox