* [PATCH] dmaengine: ioatdma: use default_groups in kobj_type
@ 2022-01-04 16:33 Greg Kroah-Hartman
2022-01-04 16:38 ` Dave Jiang
2022-01-05 7:42 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-01-04 16:33 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman, Vinod Koul, dmaengine
There are currently 2 ways to create a set of sysfs files for a
kobj_type, through the default_attrs field, and the default_groups
field. Move the ioatdma sysfs code to use default_groups field which has
been the preferred way since aa30f47cf666 ("kobject: Add support for
default attribute groups to kobj_type") so that we can soon get rid of
the obsolete default_attrs field.
Cc: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/dma/ioat/sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/ioat/sysfs.c b/drivers/dma/ioat/sysfs.c
index aa44bcd6a356..168adf28c5b1 100644
--- a/drivers/dma/ioat/sysfs.c
+++ b/drivers/dma/ioat/sysfs.c
@@ -158,8 +158,9 @@ static struct attribute *ioat_attrs[] = {
&intr_coalesce_attr.attr,
NULL,
};
+ATTRIBUTE_GROUPS(ioat);
struct kobj_type ioat_ktype = {
.sysfs_ops = &ioat_sysfs_ops,
- .default_attrs = ioat_attrs,
+ .default_groups = ioat_groups,
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: ioatdma: use default_groups in kobj_type
2022-01-04 16:33 [PATCH] dmaengine: ioatdma: use default_groups in kobj_type Greg Kroah-Hartman
@ 2022-01-04 16:38 ` Dave Jiang
2022-01-05 7:42 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2022-01-04 16:38 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel; +Cc: Vinod Koul, dmaengine
On 1/4/2022 9:33 AM, Greg Kroah-Hartman wrote:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field. Move the ioatdma sysfs code to use default_groups field which has
> been the preferred way since aa30f47cf666 ("kobject: Add support for
> default attribute groups to kobj_type") so that we can soon get rid of
> the obsolete default_attrs field.
>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/ioat/sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ioat/sysfs.c b/drivers/dma/ioat/sysfs.c
> index aa44bcd6a356..168adf28c5b1 100644
> --- a/drivers/dma/ioat/sysfs.c
> +++ b/drivers/dma/ioat/sysfs.c
> @@ -158,8 +158,9 @@ static struct attribute *ioat_attrs[] = {
> &intr_coalesce_attr.attr,
> NULL,
> };
> +ATTRIBUTE_GROUPS(ioat);
>
> struct kobj_type ioat_ktype = {
> .sysfs_ops = &ioat_sysfs_ops,
> - .default_attrs = ioat_attrs,
> + .default_groups = ioat_groups,
> };
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: ioatdma: use default_groups in kobj_type
2022-01-04 16:33 [PATCH] dmaengine: ioatdma: use default_groups in kobj_type Greg Kroah-Hartman
2022-01-04 16:38 ` Dave Jiang
@ 2022-01-05 7:42 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-01-05 7:42 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, dmaengine
On 04-01-22, 17:33, Greg Kroah-Hartman wrote:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field. Move the ioatdma sysfs code to use default_groups field which has
> been the preferred way since aa30f47cf666 ("kobject: Add support for
> default attribute groups to kobj_type") so that we can soon get rid of
> the obsolete default_attrs field.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-05 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-04 16:33 [PATCH] dmaengine: ioatdma: use default_groups in kobj_type Greg Kroah-Hartman
2022-01-04 16:38 ` Dave Jiang
2022-01-05 7:42 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox