* [PATCH] ccp: ccp_dmaengine_unregister release dma channels
@ 2022-02-28 3:15 Dāvis Mosāns
2022-03-01 21:07 ` John Allen
2022-03-09 3:21 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Dāvis Mosāns @ 2022-02-28 3:15 UTC (permalink / raw)
To: linux-kernel
Cc: Tom Lendacky, John Allen, linux-crypto, dmaengine,
Dāvis Mosāns
ccp_dmaengine_register adds dma_chan->device_node to dma_dev->channels list
but ccp_dmaengine_unregister didn't remove them.
That can cause crashes in various dmaengine methods that tries to use dma_dev->channels
Signed-off-by: Dāvis Mosāns <davispuh@gmail.com>
---
drivers/crypto/ccp/ccp-dmaengine.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
index d718db224be42..7d4b4ad1db1f3 100644
--- a/drivers/crypto/ccp/ccp-dmaengine.c
+++ b/drivers/crypto/ccp/ccp-dmaengine.c
@@ -632,6 +632,20 @@ static int ccp_terminate_all(struct dma_chan *dma_chan)
return 0;
}
+static void ccp_dma_release(struct ccp_device *ccp)
+{
+ struct ccp_dma_chan *chan;
+ struct dma_chan *dma_chan;
+ unsigned int i;
+
+ for (i = 0; i < ccp->cmd_q_count; i++) {
+ chan = ccp->ccp_dma_chan + i;
+ dma_chan = &chan->dma_chan;
+ tasklet_kill(&chan->cleanup_tasklet);
+ list_del_rcu(&dma_chan->device_node);
+ }
+}
+
int ccp_dmaengine_register(struct ccp_device *ccp)
{
struct ccp_dma_chan *chan;
@@ -736,6 +750,7 @@ int ccp_dmaengine_register(struct ccp_device *ccp)
return 0;
err_reg:
+ ccp_dma_release(ccp);
kmem_cache_destroy(ccp->dma_desc_cache);
err_cache:
@@ -752,6 +767,7 @@ void ccp_dmaengine_unregister(struct ccp_device *ccp)
return;
dma_async_device_unregister(dma_dev);
+ ccp_dma_release(ccp);
kmem_cache_destroy(ccp->dma_desc_cache);
kmem_cache_destroy(ccp->dma_cmd_cache);
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ccp: ccp_dmaengine_unregister release dma channels
2022-02-28 3:15 [PATCH] ccp: ccp_dmaengine_unregister release dma channels Dāvis Mosāns
@ 2022-03-01 21:07 ` John Allen
2022-03-09 3:21 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: John Allen @ 2022-03-01 21:07 UTC (permalink / raw)
To: Dāvis Mosāns
Cc: linux-kernel, Tom Lendacky, linux-crypto, dmaengine
On Mon, Feb 28, 2022 at 05:15:45AM +0200, Dāvis Mosāns wrote:
> ccp_dmaengine_register adds dma_chan->device_node to dma_dev->channels list
> but ccp_dmaengine_unregister didn't remove them.
> That can cause crashes in various dmaengine methods that tries to use dma_dev->channels
>
> Signed-off-by: Dāvis Mosāns <davispuh@gmail.com>
Acked-by: John Allen <john.allen@amd.com>
> ---
> drivers/crypto/ccp/ccp-dmaengine.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c
> index d718db224be42..7d4b4ad1db1f3 100644
> --- a/drivers/crypto/ccp/ccp-dmaengine.c
> +++ b/drivers/crypto/ccp/ccp-dmaengine.c
> @@ -632,6 +632,20 @@ static int ccp_terminate_all(struct dma_chan *dma_chan)
> return 0;
> }
>
> +static void ccp_dma_release(struct ccp_device *ccp)
> +{
> + struct ccp_dma_chan *chan;
> + struct dma_chan *dma_chan;
> + unsigned int i;
> +
> + for (i = 0; i < ccp->cmd_q_count; i++) {
> + chan = ccp->ccp_dma_chan + i;
> + dma_chan = &chan->dma_chan;
> + tasklet_kill(&chan->cleanup_tasklet);
> + list_del_rcu(&dma_chan->device_node);
> + }
> +}
> +
> int ccp_dmaengine_register(struct ccp_device *ccp)
> {
> struct ccp_dma_chan *chan;
> @@ -736,6 +750,7 @@ int ccp_dmaengine_register(struct ccp_device *ccp)
> return 0;
>
> err_reg:
> + ccp_dma_release(ccp);
> kmem_cache_destroy(ccp->dma_desc_cache);
>
> err_cache:
> @@ -752,6 +767,7 @@ void ccp_dmaengine_unregister(struct ccp_device *ccp)
> return;
>
> dma_async_device_unregister(dma_dev);
> + ccp_dma_release(ccp);
>
> kmem_cache_destroy(ccp->dma_desc_cache);
> kmem_cache_destroy(ccp->dma_cmd_cache);
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ccp: ccp_dmaengine_unregister release dma channels
2022-02-28 3:15 [PATCH] ccp: ccp_dmaengine_unregister release dma channels Dāvis Mosāns
2022-03-01 21:07 ` John Allen
@ 2022-03-09 3:21 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2022-03-09 3:21 UTC (permalink / raw)
To: Dāvis Mosāns
Cc: linux-kernel, thomas.lendacky, john.allen, linux-crypto,
dmaengine, davispuh
Dāvis Mosāns <davispuh@gmail.com> wrote:
> ccp_dmaengine_register adds dma_chan->device_node to dma_dev->channels list
> but ccp_dmaengine_unregister didn't remove them.
> That can cause crashes in various dmaengine methods that tries to use dma_dev->channels
>
> Signed-off-by: Dāvis Mosāns <davispuh@gmail.com>
> ---
> drivers/crypto/ccp/ccp-dmaengine.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-09 3:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-28 3:15 [PATCH] ccp: ccp_dmaengine_unregister release dma channels Dāvis Mosāns
2022-03-01 21:07 ` John Allen
2022-03-09 3:21 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).