From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F293AC433EF for ; Thu, 31 Mar 2022 05:23:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbiCaFZP (ORCPT ); Thu, 31 Mar 2022 01:25:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiCaFZO (ORCPT ); Thu, 31 Mar 2022 01:25:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A2F9FA20A; Wed, 30 Mar 2022 22:23:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0884961580; Thu, 31 Mar 2022 05:23:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B94DC340EE; Thu, 31 Mar 2022 05:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648704206; bh=eBy7+Ih0SkRIqoSoJt0V6SXGw5DK/vQX/BZHc0wYr8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mm/n9Jum+7wft5UX7zfI6APvwfOgo2tXy6SSzi8Uxk9pXWWxsELdnowKdRQd/TMh3 f+4RBVl+y29sVXfrd8HUN1KRH3T3wBQmUfmVT0pCm4CLF+PN2TiQNgFuTjg89WwOa3 5yzIvZjJ6ogpVE3Kp4AFTB9oP4lPeJRqlm/4JA5tNXiHZH6Ed/Idy5wYZ1sx0PcPja HBNQuls/byuxIqW23JCIpCrul84Lqk7idjq3nukNelghfHTCbNOp15Cqw5TL68z7RL IvKySAlilij5Dd7Wid7OIeY2kF/7Skz5S7vXX0ij+oJhZ6ncbsjpzyRogLmz4P+BSa 1mUhPhUjmgyjg== Date: Thu, 31 Mar 2022 10:53:22 +0530 From: Vinod Koul To: Martin =?utf-8?Q?Povi=C5=A1er?= Cc: Hector Martin , Sven Peter , Rob Herring , Krzysztof Kozlowski , Alyssa Rosenzweig , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Kettenis Subject: Re: [PATCH 1/2] dt-bindings: dma: Add Apple ADMAC Message-ID: References: <20220330164458.93055-1-povik+lin@cutebit.org> <20220330164458.93055-2-povik+lin@cutebit.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220330164458.93055-2-povik+lin@cutebit.org> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 30-03-22, 18:44, Martin Povišer wrote: > Apple's Audio DMA Controller (ADMAC) is used to fetch and store audio > samples on Apple SoCs from the "Apple Silicon" family. > > Signed-off-by: Martin Povišer > --- > .../devicetree/bindings/dma/apple,admac.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/apple,admac.yaml > > diff --git a/Documentation/devicetree/bindings/dma/apple,admac.yaml b/Documentation/devicetree/bindings/dma/apple,admac.yaml > new file mode 100644 > index 000000000000..34f76a9a2983 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/apple,admac.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/apple,admac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple Audio DMA Controller (ADMAC) > + > +description: | > + Apple's Audio DMA Controller (ADMAC) is used to fetch and store > + audio samples on Apple SoCs from the "Apple Silicon" family. > + > +maintainers: > + - Martin Povišer > + > +allOf: > + - $ref: "dma-controller.yaml#" > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t6000-admac > + - apple,t8103-admac > + - const: apple,admac > + > + reg: > + maxItems: 1 > + > + '#dma-cells': > + const: 1 > + > + apple,internal-irq-destination: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Index influencing internal routing of the IRQs > + within the peripheral. do you have more details for this, is this for peripheral and if so suited to be in dam-cells? > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - '#dma-cells' > + - dma-channels > + - apple,internal-irq-destination > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + dart_sio: iommu@235004000 { > + compatible = "apple,t8103-dart", "apple,dart"; > + reg = <0x2 0x35004000 0x0 0x4000>; > + interrupt-parent = <&aic>; > + interrupts = ; > + #iommu-cells = <1>; > + }; > + > + admac: dma-controller@238200000 { > + compatible = "apple,t8103-admac", "apple,admac"; > + reg = <0x2 0x38200000 0x0 0x34000>; > + dma-channels = <12>; > + interrupt-parent = <&aic>; > + interrupts = ; > + #dma-cells = <1>; > + iommus = <&dart_sio 2>; > + apple,internal-irq-destination = <1>; > + }; > -- > 2.33.0 -- ~Vinod