dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: alsa-devel@alsa-project.org, Xiubo Li <Xiubo.Lee@gmail.com>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@gmail.com>,
	kernel@pengutronix.de, NXP Linux Team <linux-imx@nxp.com>,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 10/19] dma: imx-sdma: Add multi fifo support
Date: Thu, 31 Mar 2022 10:56:09 +0530	[thread overview]
Message-ID: <YkU7cYhZUuGyWbob@matsya> (raw)
In-Reply-To: <20220328112744.1575631-11-s.hauer@pengutronix.de>

On 28-03-22, 13:27, Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

it is dmaengine: xxx

Also is this patch dependent on rest of the series, if not consider
sending separately

> diff --git a/include/linux/platform_data/dma-imx.h b/include/linux/platform_data/dma-imx.h
> index 281adbb26e6bd..4a43a048e1b4d 100644
> --- a/include/linux/platform_data/dma-imx.h
> +++ b/include/linux/platform_data/dma-imx.h
> @@ -39,6 +39,7 @@ enum sdma_peripheral_type {
>  	IMX_DMATYPE_SSI_DUAL,	/* SSI Dual FIFO */
>  	IMX_DMATYPE_ASRC_SP,	/* Shared ASRC */
>  	IMX_DMATYPE_SAI,	/* SAI */
> +	IMX_DMATYPE_MULTI_SAI,	/* MULTI FIFOs For Audio */
>  };
>  
>  enum imx_dma_prio {
> @@ -65,4 +66,10 @@ static inline int imx_dma_is_general_purpose(struct dma_chan *chan)
>  		!strcmp(chan->device->dev->driver->name, "imx-dma");
>  }
>  
> +struct sdma_peripheral_config {
> +	int n_fifos_src;
> +	int n_fifos_dst;
> +	bool sw_done;
> +};

Not more platform data :(

Can you explain this structure and why this is required? What do these
fields refer to..?

-- 
~Vinod

  parent reply	other threads:[~2022-03-31  5:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 11:27 [PATCH v2 00/19] ASoC: fsl_micfil: Driver updates Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 01/19] ASoC: fsl_micfil: Drop unnecessary register read Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 02/19] ASoC: fsl_micfil: Drop unused " Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 03/19] ASoC: fsl_micfil: drop fsl_micfil_set_mclk_rate() Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 04/19] ASoC: fsl_micfil: do not define SHIFT/MASK for single bits Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 05/19] ASoC: fsl_micfil: use GENMASK to define register bit fields Sascha Hauer
     [not found]   ` <CAA+D8APTMSLSCb386XvN3bu+uq3F1VK9NopJYpgumDF=TCCgEw@mail.gmail.com>
2022-04-07  7:38     ` Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 06/19] ASoC: fsl_micfil: use clear/set bits Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 07/19] ASoC: fsl_micfil: drop error messages from failed register accesses Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 08/19] ASoC: fsl_micfil: drop unused variables Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 09/19] dma: imx-sdma: error out on unsupported transfer types Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 10/19] dma: imx-sdma: Add multi fifo support Sascha Hauer
2022-03-29 10:55   ` Fabio Estevam
2022-03-30  7:49     ` Sascha Hauer
2022-03-31  5:26   ` Vinod Koul [this message]
2022-03-31  6:49     ` Sascha Hauer
2022-03-31  6:54       ` Vinod Koul
2022-03-31  7:58         ` Sascha Hauer
2022-04-07  7:22           ` Vinod Koul
2022-04-01 12:01         ` Sascha Hauer
2022-04-07  7:23           ` Vinod Koul
2022-04-07  7:41             ` Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 11/19] ASoC: fsl_micfil: add " Sascha Hauer
2022-03-30  7:50   ` Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 12/19] ASoC: fsl_micfil: use define for OSR default value Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 13/19] ASoC: fsl_micfil: Drop get_pdm_clk() Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 14/19] ASoC: fsl_micfil: simplify clock setting Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 15/19] ASoC: fsl_micfil: rework quality setting Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 16/19] ASoC: fsl_micfil: drop unused include Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 17/19] ASoC: fsl_micfil: drop only once used defines Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 18/19] ASoC: fsl_micfil: drop support for undocumented property Sascha Hauer
2022-03-28 11:27 ` [PATCH v2 19/19] ASoC: fsl_micfil: fold fsl_set_clock_params() into its only user Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkU7cYhZUuGyWbob@matsya \
    --to=vkoul@kernel.org \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shengjiu.wang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).