From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D2EC433EF for ; Wed, 20 Apr 2022 10:30:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349339AbiDTKc7 (ORCPT ); Wed, 20 Apr 2022 06:32:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238282AbiDTKc6 (ORCPT ); Wed, 20 Apr 2022 06:32:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FA5C3F885; Wed, 20 Apr 2022 03:30:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B8F86B81E8D; Wed, 20 Apr 2022 10:30:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE298C385A0; Wed, 20 Apr 2022 10:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650450609; bh=kEDDxF17hrgH58OVXjuIFepbkYbLgvtx7CEHRjDCwCY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NuN7WrdOgPrnpmS28LNzTXFdP0/6JFpbRoUr8/TS88N1o8Cdkyx4z17A2P6Y6NyAN 5mZ6/kGu36j0rAd+C7uf3DXMWLq6LYjta+6Mz8wX7AhgC+8qwq/yOgI36IFJdvOxGK fgiox1MxAGqv2hcK4BuHaeXsS05hug5qZJm/sCD+ZQr2B/4vyDQRTgDEw89ckih+sX asjureABj9XGif273HwHcxBenmh2LvafbGcBD6yf2Gf5gBmbSE1Ttb5b7UmC2996YX aIXXfFeH4Bi6M9/3FIUVsPQb7OUe2glfii1bl/dbBfg7X1YkdyCt/aI0O+J6OpFGON ksxKZ1CFX4e9g== Date: Wed, 20 Apr 2022 16:00:04 +0530 From: Vinod Koul To: Yunbo Yu Cc: logang@deltatee.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock() Message-ID: References: <20220418142021.1241558-1-yuyunbo519@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220418142021.1241558-1-yuyunbo519@gmail.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 18-04-22, 22:20, Yunbo Yu wrote: > It is unnecessary to call spin_lock_bh() for you are already in a tasklet. call spin_lock_bh() if you are already in a .. With that fixed, applied. Thanks > > Signed-off-by: Yunbo Yu > --- > drivers/dma/plx_dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c > index 1ffcb5ca9788..12725fa1655f 100644 > --- a/drivers/dma/plx_dma.c > +++ b/drivers/dma/plx_dma.c > @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev) > struct plx_dma_desc *desc; > u32 flags; > > - spin_lock_bh(&plxdev->ring_lock); > + spin_lock(&plxdev->ring_lock); > > while (plxdev->tail != plxdev->head) { > desc = plx_dma_get_desc(plxdev, plxdev->tail); > @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev) > plxdev->tail++; > } > > - spin_unlock_bh(&plxdev->ring_lock); > + spin_unlock(&plxdev->ring_lock); > } > > static void plx_dma_abort_desc(struct plx_dma_dev *plxdev) > -- > 2.25.1 -- ~Vinod