* [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()
@ 2022-04-18 14:20 Yunbo Yu
2022-04-18 15:54 ` Logan Gunthorpe
2022-04-20 10:30 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Yunbo Yu @ 2022-04-18 14:20 UTC (permalink / raw)
To: logang, vkoul; +Cc: dmaengine, linux-kernel, Yunbo Yu
It is unnecessary to call spin_lock_bh() for you are already in a tasklet.
Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
---
drivers/dma/plx_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
index 1ffcb5ca9788..12725fa1655f 100644
--- a/drivers/dma/plx_dma.c
+++ b/drivers/dma/plx_dma.c
@@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
struct plx_dma_desc *desc;
u32 flags;
- spin_lock_bh(&plxdev->ring_lock);
+ spin_lock(&plxdev->ring_lock);
while (plxdev->tail != plxdev->head) {
desc = plx_dma_get_desc(plxdev, plxdev->tail);
@@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
plxdev->tail++;
}
- spin_unlock_bh(&plxdev->ring_lock);
+ spin_unlock(&plxdev->ring_lock);
}
static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()
2022-04-18 14:20 [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock() Yunbo Yu
@ 2022-04-18 15:54 ` Logan Gunthorpe
2022-04-20 10:30 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Logan Gunthorpe @ 2022-04-18 15:54 UTC (permalink / raw)
To: Yunbo Yu, vkoul; +Cc: dmaengine, linux-kernel
On 2022-04-18 08:20, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for you are already in a tasklet.
>
> Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
Ah, thanks!
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> ---
> drivers/dma/plx_dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index 1ffcb5ca9788..12725fa1655f 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> struct plx_dma_desc *desc;
> u32 flags;
>
> - spin_lock_bh(&plxdev->ring_lock);
> + spin_lock(&plxdev->ring_lock);
>
> while (plxdev->tail != plxdev->head) {
> desc = plx_dma_get_desc(plxdev, plxdev->tail);
> @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> plxdev->tail++;
> }
>
> - spin_unlock_bh(&plxdev->ring_lock);
> + spin_unlock(&plxdev->ring_lock);
> }
>
> static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()
2022-04-18 14:20 [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock() Yunbo Yu
2022-04-18 15:54 ` Logan Gunthorpe
@ 2022-04-20 10:30 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-04-20 10:30 UTC (permalink / raw)
To: Yunbo Yu; +Cc: logang, dmaengine, linux-kernel
On 18-04-22, 22:20, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for you are already in a tasklet.
call spin_lock_bh() if you are already in a ..
With that fixed, applied. Thanks
>
> Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
> ---
> drivers/dma/plx_dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index 1ffcb5ca9788..12725fa1655f 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> struct plx_dma_desc *desc;
> u32 flags;
>
> - spin_lock_bh(&plxdev->ring_lock);
> + spin_lock(&plxdev->ring_lock);
>
> while (plxdev->tail != plxdev->head) {
> desc = plx_dma_get_desc(plxdev, plxdev->tail);
> @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
> plxdev->tail++;
> }
>
> - spin_unlock_bh(&plxdev->ring_lock);
> + spin_unlock(&plxdev->ring_lock);
> }
>
> static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)
> --
> 2.25.1
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-20 10:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-18 14:20 [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock() Yunbo Yu
2022-04-18 15:54 ` Logan Gunthorpe
2022-04-20 10:30 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).