From: Vinod Koul <vkoul@kernel.org>
To: Zhang Qilong <zhangqilong3@huawei.com>
Cc: angelogioacchino.delregno@collabora.com, sean.wang@mediatek.com,
matthias.bgg@gmail.com, dmaengine@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH -next v2] dmaengine: mediatek:Fix PM usage reference leak of mtk_uart_apdma_alloc_chan_resources
Date: Mon, 11 Apr 2022 19:51:44 +0530 [thread overview]
Message-ID: <YlQ5eNbPCV8KCaRz@matsya> (raw)
In-Reply-To: <20220319022142.142709-1-zhangqilong3@huawei.com>
On 19-03-22, 10:21, Zhang Qilong wrote:
> From: zhangqilong <zhangqilong3@huawei.com>
>
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> We fix it:
> 1) Replacing it with pm_runtime_resume_and_get to keep usage counter
> balanced.
> 2) Add putting operation before returning error.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2022-04-11 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 2:21 [PATCH -next v2] dmaengine: mediatek:Fix PM usage reference leak of mtk_uart_apdma_alloc_chan_resources Zhang Qilong
2022-04-11 14:21 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlQ5eNbPCV8KCaRz@matsya \
--to=vkoul@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox