From: Vinod Koul <vkoul@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Colin Ian King <colin.king@intel.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Dan Carpenter <dan.carpenter@oracle.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2] dmaengine: sh: rz-dmac: Set DMA transfer parameters based on the direction
Date: Mon, 11 Apr 2022 16:56:48 +0530 [thread overview]
Message-ID: <YlQQeIKrXS2EmYoU@matsya> (raw)
In-Reply-To: <OS0PR01MB5922B6F81F53A58C7836B5AE86EA9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On 11-04-22, 11:06, Biju Das wrote:
> > This is a deprecated field, pls do not use this...
> >
> > Above code is correct and then based on direction of the descriptor you
> > would use either src or dstn parameters
>
> OK, I get -EINVAL because of [1] as client driver is filling
> {src,dst}_addr_width based on direction.
>
> Maybe I should remove the check from this function or
> Fix [1], as it is deprecated?? Please share your views on this.
Yes please fix it, we need to remove users of direction
--
~Vinod
prev parent reply other threads:[~2022-04-11 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 16:53 [PATCH v2] dmaengine: sh: rz-dmac: Set DMA transfer parameters based on the direction Biju Das
2022-04-11 10:55 ` Vinod Koul
2022-04-11 11:06 ` Biju Das
2022-04-11 11:26 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlQQeIKrXS2EmYoU@matsya \
--to=vkoul@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=colin.king@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox