* [PATCH] dmaengine: idxd: free irq before wq type is reset
@ 2022-05-12 0:01 Dave Jiang
2022-05-16 12:50 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2022-05-12 0:01 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine
Call idxd_wq_free_irq() in the drv_disable_wq() function before
idxd_wq_reset() is called. Otherwise the wq type is reset and the irq does
not get freed.
Fixes: 63c14ae6c161 ("dmaengine: idxd: refactor wq driver enable/disable operations")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
drivers/dma/idxd/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 4617219376f7..d1dba2a3af5d 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -1385,9 +1385,9 @@ void drv_disable_wq(struct idxd_wq *wq)
idxd_wq_free_resources(wq);
idxd_wq_unmap_portal(wq);
idxd_wq_drain(wq);
+ idxd_wq_free_irq(wq);
idxd_wq_reset(wq);
percpu_ref_exit(&wq->wq_active);
- idxd_wq_free_irq(wq);
wq->type = IDXD_WQT_NONE;
wq->client_count = 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: idxd: free irq before wq type is reset
2022-05-12 0:01 [PATCH] dmaengine: idxd: free irq before wq type is reset Dave Jiang
@ 2022-05-16 12:50 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-05-16 12:50 UTC (permalink / raw)
To: Dave Jiang; +Cc: dmaengine
On 11-05-22, 17:01, Dave Jiang wrote:
> Call idxd_wq_free_irq() in the drv_disable_wq() function before
> idxd_wq_reset() is called. Otherwise the wq type is reset and the irq does
> not get freed.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-16 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-12 0:01 [PATCH] dmaengine: idxd: free irq before wq type is reset Dave Jiang
2022-05-16 12:50 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).