DMA Engine development
 help / color / mirror / Atom feed
From: Olivier dautricourt <olivierdautricourt@gmail.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: sr@denx.de, vkoul@kernel.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH v2] dmaengine: altera-msgdma: Fix kernel-doc
Date: Tue, 31 May 2022 04:46:58 +0200	[thread overview]
Message-ID: <YpWBossUokIWkDfz@olivier-3493erg> (raw)
In-Reply-To: <20220527074008.8458-1-jiapeng.chong@linux.alibaba.com>

On Fri, May 27, 2022 at 03:40:08PM +0800, Jiapeng Chong wrote:
> Fix the following W=1 kernel warnings:
> 
> drivers/dma/altera-msgdma.c:927: warning: expecting prototype for
> msgdma_dma_remove(). Prototype was for msgdma_remove() instead.
> 
> drivers/dma/altera-msgdma.c:758: warning: expecting prototype for
> msgdma_chan_remove(). Prototype was for msgdma_dev_remove() instead.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> Changes in v2:
>   -Make the commit message more clearer,replace msgdma_remove()
> with msgdma_dma_remove() in doc.

Acked-by: Olivier Dautricourt <olivierdautricourt@gmail.com>

Thanks !
> 
>  drivers/dma/altera-msgdma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
> index 6f56dfd375e3..4153c2edb049 100644
> --- a/drivers/dma/altera-msgdma.c
> +++ b/drivers/dma/altera-msgdma.c
> @@ -749,7 +749,7 @@ static irqreturn_t msgdma_irq_handler(int irq, void *data)
>  }
>  
>  /**
> - * msgdma_chan_remove - Channel remove function
> + * msgdma_dev_remove() - Device remove function
>   * @mdev: Pointer to the Altera mSGDMA device structure
>   */
>  static void msgdma_dev_remove(struct msgdma_device *mdev)
> @@ -918,7 +918,7 @@ static int msgdma_probe(struct platform_device *pdev)
>  }
>  
>  /**
> - * msgdma_dma_remove - Driver remove function
> + * msgdma_remove() - Driver remove function
>   * @pdev: Pointer to the platform_device structure
>   *
>   * Return: Always '0'
> -- 
> 2.20.1.7.g153144c
> 

      reply	other threads:[~2022-05-31  2:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27  7:40 [PATCH v2] dmaengine: altera-msgdma: Fix kernel-doc Jiapeng Chong
2022-05-31  2:46 ` Olivier dautricourt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpWBossUokIWkDfz@olivier-3493erg \
    --to=olivierdautricourt@gmail.com \
    --cc=abaci@linux.alibaba.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sr@denx.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox