From: Vinod Koul <vkoul@kernel.org>
To: dmaengine@vger.kernel.org, "Martin Povišer" <povik+lin@cutebit.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] dmaengine: apple-admac: Fix print format
Date: Fri, 10 Jun 2022 17:17:01 +0530 [thread overview]
Message-ID: <YqMvNdmolngiUNmm@matsya> (raw)
In-Reply-To: <20220610043117.39337-1-vkoul@kernel.org>
On 10-06-22, 10:01, Vinod Koul wrote:
> We get a warning (treated as error now)
> drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':
> drivers/dma/apple-admac.c:209:26: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
> 209 | dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
>
> Use %lx for priniting the flag
I have picked this one
>
> Fixes: b127315d9a78 ("dmaengine: apple-admac: Add Apple ADMAC driver")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
added bot as report too
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/dma/apple-admac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c
> index 2425069c186d..c502f8c3aca7 100644
> --- a/drivers/dma/apple-admac.c
> +++ b/drivers/dma/apple-admac.c
> @@ -206,7 +206,7 @@ static void admac_cyclic_write_one_desc(struct admac_data *ad, int channo,
> /* If happens means we have buggy code */
> WARN_ON_ONCE(addr + tx->period_len > tx->buf_end);
>
> - dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
> + dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%lx\n",
> channo, &addr, tx->period_len, FLAG_DESC_NOTIFY);
>
> writel_relaxed(addr, ad->base + REG_DESC_WRITE(channo));
> --
> 2.34.3
--
~Vinod
prev parent reply other threads:[~2022-06-10 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 4:31 [PATCH] dmaengine: apple-admac: Fix print format Vinod Koul
2022-06-10 11:47 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqMvNdmolngiUNmm@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=povik+lin@cutebit.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox