From: Vinod Koul <vkoul@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Hui Wang <hui.wang@canonical.com>,
dmaengine@vger.kernel.org, shawnguo@kernel.org,
yibin.gong@nxp.com
Subject: Re: [PATCH] dmaengine: imx-sdma: Setting DMA_PRIVATE capability during the probe
Date: Fri, 1 Jul 2022 22:04:58 +0530 [thread overview]
Message-ID: <Yr8iMkBNMowEG+uF@matsya> (raw)
In-Reply-To: <20220620083310.GV2387@pengutronix.de>
On 20-06-22, 10:33, Sascha Hauer wrote:
> On Tue, May 24, 2022 at 03:49:33PM +0800, Hui Wang wrote:
> > + dma_cap_set(DMA_PRIVATE, sdma->dma_device.cap_mask);
>
> I am not sure about the impacts on the memcpy capability of the SDMA
> driver when setting this flag. It looks like this flag influences the
> way suitable channels are picked for memcpy, but I don't understand
> the code just by looking at it. I see that several other drivers
> providing memcpy set this flag as well, so I guess it's ok to set it,
> but it would be good to hear a word from Vinod about it.
So DMA_PRIVATE is used to make channel not available for general dma
allocation. So yes it would impact dma memcpy which is about allocating
generically.
--
~Vinod
prev parent reply other threads:[~2022-07-01 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:49 [PATCH] dmaengine: imx-sdma: Setting DMA_PRIVATE capability during the probe Hui Wang
2022-06-17 2:48 ` Hui Wang
2022-06-20 8:33 ` Sascha Hauer
2022-07-01 16:34 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr8iMkBNMowEG+uF@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=hui.wang@canonical.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox