From: Vinod Koul <vkoul@kernel.org>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>, Tony Zhu <tony.zhu@intel.com>,
dmaengine@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Li Zhang <li4.zhang@intel.com>
Subject: Re: [PATCH] dmaengine: idxd: Correct IAX operation code names
Date: Thu, 21 Jul 2022 18:11:23 +0530 [thread overview]
Message-ID: <YtlJcwuIjw8v9wA0@matsya> (raw)
In-Reply-To: <20220707002052.1546361-1-fenghua.yu@intel.com>
On 06-07-22, 17:20, Fenghua Yu wrote:
> Some IAX operation code nomenclatures are misleading or don't match with
> others:
>
> 1. Operation code 0x4c is Zero Compress 32. IAX_OPCODE_DECOMP_32 is a
> misleading name. Change it to IAX_OPCODE_ZERO_COMP_32.
> 2. Operation code 0x4d is Zero Compress 16. IAX_OPCODE_DECOMP_16 is a
> misleading name. Change it to IAX_OPCODE_ZERO_COMP_16.
> 3. IAX_OPCDE_FIND_UNIQUE is corrected to match with other nomenclatures.
Applied, thanks
>
> Co-developed-by: Li Zhang <li4.zhang@intel.com>
> Signed-off-by: Li Zhang <li4.zhang@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> include/uapi/linux/idxd.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
> index bce7c43657d5..095299c75828 100644
> --- a/include/uapi/linux/idxd.h
> +++ b/include/uapi/linux/idxd.h
> @@ -89,14 +89,14 @@ enum iax_opcode {
> IAX_OPCODE_CRC64,
> IAX_OPCODE_ZERO_DECOMP_32 = 0x48,
> IAX_OPCODE_ZERO_DECOMP_16,
> - IAX_OPCODE_DECOMP_32 = 0x4c,
> - IAX_OPCODE_DECOMP_16,
> + IAX_OPCODE_ZERO_COMP_32 = 0x4c,
> + IAX_OPCODE_ZERO_COMP_16,
> IAX_OPCODE_SCAN = 0x50,
> IAX_OPCODE_SET_MEMBER,
> IAX_OPCODE_EXTRACT,
> IAX_OPCODE_SELECT,
> IAX_OPCODE_RLE_BURST,
> - IAX_OPCDE_FIND_UNIQUE,
> + IAX_OPCODE_FIND_UNIQUE,
> IAX_OPCODE_EXPAND,
> };
>
> --
> 2.32.0
--
~Vinod
prev parent reply other threads:[~2022-07-21 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 0:20 [PATCH] dmaengine: idxd: Correct IAX operation code names Fenghua Yu
2022-07-21 12:41 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtlJcwuIjw8v9wA0@matsya \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=li4.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox