From: Vinod Koul <vkoul@kernel.org>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: michal.simek@xilinx.com, m.tretter@pengutronix.de,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
git@amd.com, Shravya Kumbham <shravya.kumbham@xilinx.com>,
Harini Katakam <harini.katakam@xilinx.com>
Subject: Re: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the coverity warning
Date: Mon, 5 Sep 2022 11:56:14 +0530 [thread overview]
Message-ID: <YxWWhov7bjz2J+Ur@matsya> (raw)
In-Reply-To: <1653378553-28548-1-git-send-email-radhey.shyam.pandey@amd.com>
On 24-05-22, 13:19, Radhey Shyam Pandey wrote:
> From: Shravya Kumbham <shravya.kumbham@xilinx.com>
>
> Typecast the flags variable with (enum dma_ctrl_flags) in
> zynqmp_dma_prep_memcpy function to fix the coverity warning.
Applied, thanks
>
> Addresses-Coverity: Event mixed_enum_type.
> Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
> NOTE- This patch was sent to dmaengine mailing list[1] and
> there was a suggestion from Michael Tretter to change the
> signature of the dmaengine_prep_dma_memcpy() engine to accept
> "enum dma_ctrl_flags flags" instead of "unsigned long flags".
>
> All device_prep_dma_* API variants have ulong flags argument.
> So this is a wider question if we want to change these APIs?
> Also there are existing users of these public APIs.
It would be very nice to do this change but users would need to be
updated as well, patches are welcome
--
~Vinod
prev parent reply other threads:[~2022-09-05 6:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:49 [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the coverity warning Radhey Shyam Pandey
2022-07-21 14:23 ` Pandey, Radhey Shyam
2022-09-05 6:26 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxWWhov7bjz2J+Ur@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=git@amd.com \
--cc=harini.katakam@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=michal.simek@xilinx.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=shravya.kumbham@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox