From: Vinod Koul <vkoul@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
Thomas Pedersen <twp@codeaurora.org>,
Jonathan McDowell <noodles@earth.li>,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] dmaengine: qcom-adm: fix wrong calling convention for prep_slave_sg
Date: Thu, 29 Sep 2022 22:14:34 +0530 [thread overview]
Message-ID: <YzXLcvv1eiRXzrND@matsya> (raw)
In-Reply-To: <20220916041256.7104-1-ansuelsmth@gmail.com>
On 16-09-22, 06:12, Christian Marangi wrote:
> The calling convention for pre_slave_sg is to return NULL on error and
> provide an error log to the system. Qcom-adm instead provide error
> pointer when an error occur. This indirectly cause kernel panic for
> example for the nandc driver that checks only if the pointer returned by
> device_prep_slave_sg is not NULL. Returning an error pointer makes nandc
> think the device_prep_slave_sg function correctly completed and makes
> the kernel panics later in the code.
>
> While nandc is the one that makes the kernel crash, it was pointed out
> that the real problem is qcom-adm not following calling convention for
> that function.
>
> To fix this, drop returning error pointer and return NULL with an error
> log.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2022-09-29 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 4:12 [PATCH] dmaengine: qcom-adm: fix wrong calling convention for prep_slave_sg Christian Marangi
2022-09-29 16:44 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzXLcvv1eiRXzrND@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@earth.li \
--cc=stable@vger.kernel.org \
--cc=twp@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox