From: Vinod Koul <vkoul@kernel.org>
To: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Cc: dmaengine@vger.kernel.org
Subject: Re: [PATCH 1/3] dmaengine: ae4dma: Remove deprecated PCI IDs
Date: Mon, 10 Feb 2025 19:29:45 +0530 [thread overview]
Message-ID: <Z6oGUao+26rThmub@vaman> (raw)
In-Reply-To: <20250203162511.911946-2-Basavaraj.Natikar@amd.com>
On 03-02-25, 21:55, Basavaraj Natikar wrote:
> Two previously used PCI IDs are deprecated and should not be used for
> AE4DMA. Hence, remove as they are unsupported for AE4DMA.
>
> Fixes: 90a30e268d9b ("dmaengine: ae4dma: Add AMD ae4dma controller driver")
Why is this a fix?
> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
> ---
> drivers/dma/amd/ae4dma/ae4dma-pci.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/amd/ae4dma/ae4dma-pci.c b/drivers/dma/amd/ae4dma/ae4dma-pci.c
> index aad0dc4294a3..7f96843f5215 100644
> --- a/drivers/dma/amd/ae4dma/ae4dma-pci.c
> +++ b/drivers/dma/amd/ae4dma/ae4dma-pci.c
> @@ -137,8 +137,6 @@ static void ae4_pci_remove(struct pci_dev *pdev)
> }
>
> static const struct pci_device_id ae4_pci_table[] = {
> - { PCI_VDEVICE(AMD, 0x14C8), },
> - { PCI_VDEVICE(AMD, 0x14DC), },
> { PCI_VDEVICE(AMD, 0x149B), },
> /* Last entry must be zero */
> { 0, }
> --
> 2.25.1
--
~Vinod
next prev parent reply other threads:[~2025-02-10 13:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 16:25 [PATCH 0/3] Fixes to the AE4DMA Basavaraj Natikar
2025-02-03 16:25 ` [PATCH 1/3] dmaengine: ae4dma: Remove deprecated PCI IDs Basavaraj Natikar
2025-02-10 13:59 ` Vinod Koul [this message]
2025-02-10 14:18 ` Basavaraj Natikar
2025-02-03 16:25 ` [PATCH 2/3] dmaengine: ae4dma: Use the MSI count and its corresponding IRQ number Basavaraj Natikar
2025-02-03 16:25 ` [PATCH 3/3] dmaengine: ptdma: Utilize the AE4DMA engine's multi-queue functionality Basavaraj Natikar
2025-02-10 14:18 ` Vinod Koul
2025-02-10 14:26 ` Basavaraj Natikar
2025-02-10 14:37 ` Basavaraj Natikar
2025-03-10 21:06 ` [PATCH 0/3] Fixes to the AE4DMA Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6oGUao+26rThmub@vaman \
--to=vkoul@kernel.org \
--cc=Basavaraj.Natikar@amd.com \
--cc=dmaengine@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox