From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yi Sun <yi.sun@intel.com>
Cc: dave.jiang@intel.com, anil.s.keshavamurthy@intel.com,
vkoul@kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, gordon.jin@intel.com,
yi.sun@linux.intel.com
Subject: Re: [PATCH] dma/idxd: Remove __packed from structures
Date: Thu, 20 Mar 2025 12:51:31 +0200 [thread overview]
Message-ID: <Z9vzM7UedzpkdHKZ@smile.fi.intel.com> (raw)
In-Reply-To: <20250320081807.3688123-1-yi.sun@intel.com>
On Thu, Mar 20, 2025 at 04:18:07PM +0800, Yi Sun wrote:
> The __packed attribute introduces potential unaligned memory accesses
> and endianness portability issues. Instead of relying on compiler-specific
> packing, it's much better to explicitly fill structure gaps using padding
> fields, ensuring natural alignment.
>
> Since all previously __packed structures already enforce proper alignment
> through manual padding, the __packed qualifiers are unnecessary and can be
> safely removed.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-20 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 8:18 [PATCH] dma/idxd: Remove __packed from structures Yi Sun
2025-03-20 10:51 ` Andy Shevchenko [this message]
2025-03-20 15:22 ` Dave Jiang
2025-03-20 15:45 ` Andy Shevchenko
2025-04-02 20:47 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9vzM7UedzpkdHKZ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gordon.jin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=yi.sun@intel.com \
--cc=yi.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox