From: Christoph Hellwig <hch@infradead.org>
To: Kelvin Cao <kelvin.cao@microchip.com>
Cc: vkoul@kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, logang@deltatee.com,
george.ge@microchip.com, christophe.jaillet@wanadoo.fr,
hch@infradead.org
Subject: Re: [PATCH v5 1/1] dmaengine: switchtec-dma: Introduce Switchtec DMA engine PCI driver
Date: Thu, 18 May 2023 20:56:47 -0700 [thread overview]
Message-ID: <ZGbzf6G5OpK0mRXN@infradead.org> (raw)
In-Reply-To: <20230518165920.897620-2-kelvin.cao@microchip.com>
> +/*
> + * Use vender/device and class to identify the DMA function.
> + */
> +#define SWITCHTEC_DMA_DEVICE(device_id) \
I'd word this as:
/*
* Also use the class code to identify the devices, as some of the
* device IDs are also used for other devices with other classes by
* Microsemi.
*/
to emphasis on why this macro even exists.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-05-19 3:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 16:59 [PATCH v5 0/1] Switchtec Switch DMA Engine Driver Kelvin Cao
2023-05-18 16:59 ` [PATCH v5 1/1] dmaengine: switchtec-dma: Introduce Switchtec DMA engine PCI driver Kelvin Cao
2023-05-19 3:56 ` Christoph Hellwig [this message]
2023-05-19 11:22 ` Vinod Koul
2023-05-23 6:01 ` Christoph Hellwig
2023-05-24 16:58 ` Kelvin.Cao
2023-07-24 16:32 ` Christoph Hellwig
2023-07-24 23:54 ` Kelvin.Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGbzf6G5OpK0mRXN@infradead.org \
--to=hch@infradead.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmaengine@vger.kernel.org \
--cc=george.ge@microchip.com \
--cc=kelvin.cao@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).