From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BAEFC77B7A for ; Fri, 19 May 2023 11:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbjESL1O (ORCPT ); Fri, 19 May 2023 07:27:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230250AbjESL1N (ORCPT ); Fri, 19 May 2023 07:27:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9159DCF; Fri, 19 May 2023 04:27:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 239EF656E8; Fri, 19 May 2023 11:27:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A47D8C433EF; Fri, 19 May 2023 11:27:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684495631; bh=qjcsKYz9V3tQWvthXbfWyiuA1p7/z0QH8gQxDtAlfE8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uCIJGdMbQCusrgBjBbAoCuOFFISxJT/4gFJiHdgP+lcjXjzxarbB5KYqQHj3bHGFV Lwn85tBg7ZgbRFjmicOScmIrIlB5WwKG4uT/eELoPTLXl5E9XZ1gEmb3odyjkKthKr Nvq+K2WEosSYO7E04SxA5d6JrpWoFOlv7klcaUXm5KuecXlC6BsLh5F5Xz6vEM/4Zm PpUBHYrR0sHAkorShiTZjHm5c9Be97c7lfF8zQx1Qupy50f9N1vNLYIi4w3o0bqVba W/iy5eWcojn1r/cXB3ziD9KGVYLP43oWJlfi/5smoPCIAAiwIQEJX0EFkHasjzHyQO EwUokvMx+PnPQ== Date: Fri, 19 May 2023 16:57:06 +0530 From: Vinod Koul To: Cai Huoqing Cc: Serge Semin , Gustavo Pimentel , Jingoo Han , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v10 0/4] dmaengine: dw-edma: Add support for native HDMA Message-ID: References: <20230517030115.21093-1-cai.huoqing@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230517030115.21093-1-cai.huoqing@linux.dev> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 17-05-23, 11:01, Cai Huoqing wrote: > Add support for HDMA NATIVE, as long the IP design has set > the compatible register map parameter-HDMA_NATIVE, > which allows compatibility for native HDMA register configuration. > > The HDMA Hyper-DMA IP is an enhancement of the eDMA embedded-DMA IP. > And the native HDMA registers are different from eDMA, > so this patch add support for HDMA NATIVE mode. > > HDMA write and read channels operate independently to maximize > the performance of the HDMA read and write data transfer over > the link When you configure the HDMA with multiple read channels, > then it uses a round robin (RR) arbitration scheme to select > the next read channel to be serviced.The same applies when > youhave multiple write channels. > > The native HDMA driver also supports a maximum of 16 independent > channels (8 write + 8 read), which can run simultaneously. > Both SAR (Source Address Register) and DAR (Destination Address Register) > are aligned to byte. > > Cai Huoqing (1): > dmaengine: dw-edma: Add support for native HDMA > > Cai huoqing (3): > dmaengine: dw-edma: Rename dw_edma_core_ops structure to > dw_edma_plat_ops > dmaengine: dw-edma: Create a new dw_edma_core_ops structure to > abstract controller operation > dmaengine: dw-edma: Add HDMA DebugFS support You should have a single name for all these patches :-( > > Tested-by: Serge Semin > > v9->v10: > 1.Update commit log. > 2.rebase for dma-next > > v9 link: > https://lore.kernel.org/lkml/20230413033156.93751-1-cai.huoqing@linux.dev/ > > drivers/dma/dw-edma/Makefile | 8 +- > drivers/dma/dw-edma/dw-edma-core.c | 86 ++---- > drivers/dma/dw-edma/dw-edma-core.h | 58 ++++ > drivers/dma/dw-edma/dw-edma-pcie.c | 4 +- > drivers/dma/dw-edma/dw-edma-v0-core.c | 85 +++++- > drivers/dma/dw-edma/dw-edma-v0-core.h | 14 +- > drivers/dma/dw-edma/dw-hdma-v0-core.c | 296 +++++++++++++++++++ > drivers/dma/dw-edma/dw-hdma-v0-core.h | 17 ++ > drivers/dma/dw-edma/dw-hdma-v0-debugfs.c | 170 +++++++++++ > drivers/dma/dw-edma/dw-hdma-v0-debugfs.h | 22 ++ > drivers/dma/dw-edma/dw-hdma-v0-regs.h | 129 ++++++++ > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > include/linux/dma/edma.h | 7 +- > 13 files changed, 807 insertions(+), 91 deletions(-) > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.c > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.h > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.c > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.h > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-regs.h > > -- > 2.34.1 -- ~Vinod