From: Vinod Koul <vkoul@kernel.org>
To: hanyu001@208suo.com
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: at_hdmac: "(foo*)" should be "(foo *)"
Date: Wed, 2 Aug 2023 00:00:03 +0530 [thread overview]
Message-ID: <ZMlPKwvyBO22aOdp@matsya> (raw)
In-Reply-To: <902c5769afd77f600c9bef24da0da34f@208suo.com>
On 19-07-23, 16:48, hanyu001@208suo.com wrote:
> This patch fixes the checkpatch.pl error:
>
> ./drivers/dma/at_hdmac.c:1119: ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Yu Han <hanyu001@208suo.com>
Thanks for the patch, the From for this patch should match the
signed-off name, pls fix and resend
> ---
> drivers/dma/at_hdmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index ee3a219..af747a7 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1116,7 +1116,7 @@ static int atdma_create_memset_lli(struct dma_chan
> *chan,
> /* Only the first byte of value is to be used according to dmaengine */
> fill_pattern = (char)value;
>
> - *(u32*)vaddr = (fill_pattern << 24) |
> + *(u32 *)vaddr = (fill_pattern << 24) |
> (fill_pattern << 16) |
> (fill_pattern << 8) |
> fill_pattern;
--
~Vinod
prev parent reply other threads:[~2023-08-01 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_0348568B118A57A1F34115B6FB1D12F38008@qq.com>
2023-07-19 8:48 ` [PATCH] dma: at_hdmac: "(foo*)" should be "(foo *)" hanyu001
2023-08-01 18:30 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMlPKwvyBO22aOdp@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=hanyu001@208suo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).