* [PATCH] dma: at_hdmac: "(foo*)" should be "(foo *)"
[not found] <tencent_0348568B118A57A1F34115B6FB1D12F38008@qq.com>
@ 2023-07-19 8:48 ` hanyu001
2023-08-01 18:30 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: hanyu001 @ 2023-07-19 8:48 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine, linux-kernel
This patch fixes the checkpatch.pl error:
./drivers/dma/at_hdmac.c:1119: ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Yu Han <hanyu001@208suo.com>
---
drivers/dma/at_hdmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index ee3a219..af747a7 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -1116,7 +1116,7 @@ static int atdma_create_memset_lli(struct dma_chan
*chan,
/* Only the first byte of value is to be used according to
dmaengine */
fill_pattern = (char)value;
- *(u32*)vaddr = (fill_pattern << 24) |
+ *(u32 *)vaddr = (fill_pattern << 24) |
(fill_pattern << 16) |
(fill_pattern << 8) |
fill_pattern;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dma: at_hdmac: "(foo*)" should be "(foo *)"
2023-07-19 8:48 ` [PATCH] dma: at_hdmac: "(foo*)" should be "(foo *)" hanyu001
@ 2023-08-01 18:30 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2023-08-01 18:30 UTC (permalink / raw)
To: hanyu001; +Cc: dmaengine, linux-kernel
On 19-07-23, 16:48, hanyu001@208suo.com wrote:
> This patch fixes the checkpatch.pl error:
>
> ./drivers/dma/at_hdmac.c:1119: ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Yu Han <hanyu001@208suo.com>
Thanks for the patch, the From for this patch should match the
signed-off name, pls fix and resend
> ---
> drivers/dma/at_hdmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index ee3a219..af747a7 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1116,7 +1116,7 @@ static int atdma_create_memset_lli(struct dma_chan
> *chan,
> /* Only the first byte of value is to be used according to dmaengine */
> fill_pattern = (char)value;
>
> - *(u32*)vaddr = (fill_pattern << 24) |
> + *(u32 *)vaddr = (fill_pattern << 24) |
> (fill_pattern << 16) |
> (fill_pattern << 8) |
> fill_pattern;
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-01 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_0348568B118A57A1F34115B6FB1D12F38008@qq.com>
2023-07-19 8:48 ` [PATCH] dma: at_hdmac: "(foo*)" should be "(foo *)" hanyu001
2023-08-01 18:30 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).