Re: [PATCH v2 2/5] dmaengine: dw-edma: Typos fixes

Serge Semin
2023-10-11T10:38:16Z

On Wed, Oct 11, 2023 at 09:23:50AM +0200, Köry Maincent wrote:
> On Tue, 10 Oct 2023 20:29:06 +0530
> Manivannan Sadhasivam <mani@kernel.org> wrote:
>
> > On Mon, Oct 02, 2023 at 03:17:46PM +0200, Köry Maincent wrote:
> > > From: Kory Maincent <kory.maincent@bootlin.com>
> > >
> > > Fix "HDMA_V0_REMOTEL_STOP_INT_EN" typo error.
> > > Fix "HDMA_V0_LOCAL_STOP_INT_EN" to "HDMA_V0_LOCAL_ABORT_INT_EN" as the STOP
> > > bit is already set in the same line.
> > >
> >
> > You should split this into two patches. First one is a typo and is harmless,
> > but the second is a _bug_.
>
> Thanks for your review.
> Ok I will do so.
> Serge if it is ok for you I will keep your reviewed by on the two separate
> patches.

Yeah, it's ok.

-Serge(y)