Re: [PATCH v5 1/2] dt-bindings: dma: Add Loongson-1 DMA

Conor Dooley
2023-09-28T16:42:14Z

[-- Attachment #1: Type: text/plain, Size: 2729 bytes --]

Hey,

On Thu, Sep 28, 2023 at 08:19:52PM +0800, Keguang Zhang wrote:
> Add devicetree binding document for Loongson-1 DMA.
>
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> V4 -> V5:
> A newly added patch
>
> .../bindings/dma/loongson,ls1x-dma.yaml | 64 +++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml
>
> diff --git a/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml b/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml
> new file mode 100644
> index 000000000000..51b45d998a58
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/loongson,ls1x-dma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Loongson-1 DMA Controller
> +
> +maintainers:
> + - Keguang Zhang <keguang.zhang@gmail.com>
> +
> +description: |

This | isn't required as you have no formatting to preserve here.

> + Loongson-1 DMA controller provides 3 independent channels for
> + peripherals such as NAND and AC97.
> +
> +properties:
> + compatible:
> + enum:
> + - loongson,ls1b-dma
> + - loongson,ls1c-dma

From a skim of the driver, these two devices seem to be compatible,
and therefore one should fall back to the other.

> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description: Each channel has a dedicated interrupt line.
> + minItems: 1
> + maxItems: 3
> +
> + interrupt-names:
> + minItems: 1
> + items:
> + - pattern: ch0
> + - pattern: ch1
> + - pattern: ch2
> +
> + '#dma-cells':
> + description: The single cell represents the channel index.

This description is unnecessary.

> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> + - '#dma-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + dma: dma-controller@1fd01160 {

This label is unused.

> + compatible = "loongson,ls1b-dma";
> + reg = <0x1fd01160 0x18>;
> +
> + interrupt-parent = <&intc0>;
> + interrupts = <13 IRQ_TYPE_EDGE_RISING>,
> + <14 IRQ_TYPE_EDGE_RISING>,
> + <15 IRQ_TYPE_EDGE_RISING>;

Odd mixed indentation here. Bindings use spaces only.

Thanks,
Conor.

> + interrupt-names = "ch0", "ch1", "ch2";
> +
> + #dma-cells = <1>;
> + };
> --
> 2.39.2
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]