Re: [PATCH v5 1/2] dt-bindings: dma: Add Loongson-1 DMA

Krzysztof Kozlowski
2023-10-08T11:15:16Z

On 07/10/2023 07:45, Keguang Zhang wrote:

>
>>> + Loongson-1 DMA controller provides 3 independent channels for
>>> + peripherals such as NAND and AC97.
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - loongson,ls1b-dma
>>> + - loongson,ls1c-dma
>>
>> From a skim of the driver, these two devices seem to be compatible,
>> and therefore one should fall back to the other.
>>
> Got it. How about changing to one const?
> compatible:
> const: loongson,ls1-dma

No, because there is no fallback here.

Best regards,
Krzysztof