From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Vinod Koul <vkoul@kernel.org>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v5 39/39] dma: cirrus: remove platform code
Date: Wed, 22 Nov 2023 14:31:18 +0200 [thread overview]
Message-ID: <ZV30llA4yDUs2G-Z@smile.fi.intel.com> (raw)
In-Reply-To: <20231122-ep93xx-v5-39-d59a76d5df29@maquefel.me>
On Wed, Nov 22, 2023 at 12:00:17PM +0300, Nikita Shubin wrote:
> Remove DMA platform header, from now on we use device tree for dma
DMA
> clients.
...
> + if (device_is_compatible(chan->device->dev, "cirrus,ep9301-dma-m2p"))
> + return true;
> +
> + return !strcmp(dev_name(chan->device->dev), "ep93xx-dma-m2p");
Haven't you introduced an inliner with the similar flow? Why not reuse it?
...
> +/**
> + * ep93xx_dma_chan_direction - returns direction the channel can be used
> + * @chan: channel
> + *
> + * This function can be used in filter functions to find out whether the
> + * channel supports given DMA direction. Only M2P channels have such
> + * limitation, for M2M channels the direction is configurable.
I believe
scripts/kernel-doc -v -none -Wall ...
against this file (and maybe others!) will complain ("no return section"
or alike).
> + */
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-22 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 8:59 [PATCH v5 00/39] ep93xx device tree conversion Nikita Shubin via B4 Relay
2023-11-22 8:59 ` [PATCH v5 08/39] dt-bindings: dma: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2023-11-22 11:02 ` Rob Herring
2023-11-22 15:44 ` Rob Herring
2023-11-22 18:26 ` Krzysztof Kozlowski
2023-11-22 8:59 ` [PATCH v5 09/39] dma: cirrus: add DT support for " Nikita Shubin via B4 Relay
2023-11-22 12:10 ` Andy Shevchenko
2023-11-22 9:00 ` [PATCH v5 39/39] dma: cirrus: remove platform code Nikita Shubin via B4 Relay
2023-11-22 12:31 ` Andy Shevchenko [this message]
2023-12-11 12:10 ` Nikita Shubin
2023-11-22 10:26 ` [PATCH v5 00/39] ep93xx device tree conversion Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV30llA4yDUs2G-Z@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alexander.sverdlin@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox