From: Frank Li <Frank.li@nxp.com>
To: Xiaolei Wang <xiaolei.wang@windriver.com>
Cc: vkoul@kernel.org, imx@lists.linux.dev, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dmaengine: fsl-edma: Add judgment on enabling round robin arbitration
Date: Mon, 13 Nov 2023 10:15:27 -0500 [thread overview]
Message-ID: <ZVI9jzr7LxkTozWW@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20231113131105.1361293-2-xiaolei.wang@windriver.com>
On Mon, Nov 13, 2023 at 09:11:05PM +0800, Xiaolei Wang wrote:
> Add judgment on enabling round robin arbitration to avoid
> exceptions if this function is not supported.
>
> Call trace:
> fsl_edma_resume_early+0x1d4/0x208
> dpm_run_callback+0xd4/0x304
> device_resume_early+0xb0/0x208
> dpm_resume_early+0x224/0x528
> suspend_devices_and_enter+0x3e4/0xd00
> pm_suspend+0x3c4/0x910
> state_store+0x90/0x124
> kobj_attr_store+0x48/0x64
> sysfs_kf_write+0x84/0xb4
> kernfs_fop_write_iter+0x19c/0x264
> vfs_write+0x664/0x858
> ksys_write+0xc8/0x180
> __arm64_sys_write+0x44/0x58
> invoke_syscall+0x5c/0x178
> el0_svc_common.constprop.0+0x11c/0x14c
> do_el0_svc+0x30/0x40
> el0_svc+0x58/0xa8
> el0t_64_sync_handler+0xc0/0xc4
> el0t_64_sync+0x190/0x194
>
> Fixes: 82d149b86d31 ("dmaengine: fsl-edma: add PM suspend/resume support")
It should be
Fixes: 72f5801a4e2b7 ("dmaengine: fsl-edma: integrate v3 support")
FSL_EDMA_DRV_SPLIT_REG is added at above commit.
The same to the second patch.
Frank
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
> ---
> drivers/dma/fsl-edma-main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 52577fffc62b..aea7a703dda7 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -665,7 +665,8 @@ static int fsl_edma_resume_early(struct device *dev)
> fsl_edma_chan_mux(fsl_chan, fsl_chan->slave_id, true);
> }
>
> - edma_writel(fsl_edma, EDMA_CR_ERGA | EDMA_CR_ERCA, regs->cr);
> + if (!(fsl_edma->drvdata->flags & FSL_EDMA_DRV_SPLIT_REG))
> + edma_writel(fsl_edma, EDMA_CR_ERGA | EDMA_CR_ERCA, regs->cr);
>
> return 0;
> }
> --
> 2.25.1
>
prev parent reply other threads:[~2023-11-13 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 13:11 [PATCH 1/2] dmaengine: fsl-edma: Do not suspend and resume the masked dma channel when the system is sleeping Xiaolei Wang
2023-11-13 13:11 ` [PATCH 2/2] dmaengine: fsl-edma: Add judgment on enabling round robin arbitration Xiaolei Wang
2023-11-13 15:15 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVI9jzr7LxkTozWW@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox