From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>, Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH v1 1/1] idma64: Don't try to serve interrupts when device is powered off
Date: Wed, 20 Mar 2024 18:36:10 +0200 [thread overview]
Message-ID: <ZfsQeo8NxOuHVbfE@smile.fi.intel.com> (raw)
In-Reply-To: <20240320163210.1153679-1-andriy.shevchenko@linux.intel.com>
On Wed, Mar 20, 2024 at 06:32:10PM +0200, Andy Shevchenko wrote:
> When iDMA 64-bit device is powered off, the IRQ status register
> is all 1:s. This is never happen in real case and signalling that
> the device is simply powered off. Don't try to serve interrupts
> that are not ours.
...
> dev_vdbg(idma64->dma.dev, "%s: status=%#x\n", __func__, status);
Dunno if I actually also need to move this message to after the checks...
> + /* Since IRQ may be shared, check if DMA controller is powered on */
> + if (status == GENMASK(31, 0))
> + return IRQ_NONE;
> +
> /* Check if we have any interrupt from the DMA controller */
> if (!status)
> return IRQ_NONE;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-20 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 16:32 [PATCH v1 1/1] idma64: Don't try to serve interrupts when device is powered off Andy Shevchenko
2024-03-20 16:36 ` Andy Shevchenko [this message]
2024-03-21 11:49 ` Heiner Kallweit
2024-03-21 12:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfsQeo8NxOuHVbfE@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox