From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Paul Cercueil <paul@crapouillou.net>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v1 2/4] dmaengine: Use dma_request_channel() instead of __dma_request_channel()
Date: Tue, 8 Oct 2024 20:12:15 +0300 [thread overview]
Message-ID: <ZwVn7witZ3Bt8ktu@black.fi.intel.com> (raw)
In-Reply-To: <ZwQF0skPo0zJ7Uzd@lizhi-Precision-Tower-5810>
On Mon, Oct 07, 2024 at 12:01:22PM -0400, Frank Li wrote:
> On Mon, Oct 07, 2024 at 06:06:46PM +0300, Andy Shevchenko wrote:
> > Let's reduce the surface of the use of __dma_request_channel().
> > Hopefully we can make it internall to the DMA drivers or kill for good
> > completely.
>
> Suggest:
>
> Reduce use internal __dma_request_channel() function in public
> dmaengine.h
Okay.
> I think this change is okay, but I hope the following patches, which make
> __dma_request_channel() as internal only. otherwise, it looks not necessary.
As explained in the commit message it's the first baby step to this
direction. But sure, when I have more time I'll continue. In any case
I think this change is good on this own as it shows the use inside the
header. The people who want to have an example of the use may wrongly
take the existing code as "good to go" and this even might pass the
review somewhere. That said, it's not only reducing the use, but has an
educational purpose as well.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-08 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 15:06 [PATCH v1 0/4] dmaengine: dma_request_chan*() amendments Andy Shevchenko
2024-10-07 15:06 ` [PATCH v1 1/4] dmaengine: Replace dma_request_slave_channel() by dma_request_chan() Andy Shevchenko
2024-10-07 15:52 ` Frank Li
2024-10-08 17:08 ` Andy Shevchenko
2024-10-07 15:06 ` [PATCH v1 2/4] dmaengine: Use dma_request_channel() instead of __dma_request_channel() Andy Shevchenko
2024-10-07 16:01 ` Frank Li
2024-10-08 17:12 ` Andy Shevchenko [this message]
2024-10-07 15:06 ` [PATCH v1 3/4] dmaengine: Add a comment on why it's okay when kasprintf() fails Andy Shevchenko
2024-10-07 15:51 ` Frank Li
2024-10-08 17:16 ` Andy Shevchenko
2024-10-07 15:06 ` [PATCH v1 4/4] dmaengine: Unify checks in dma_request_chan() Andy Shevchenko
2024-10-07 16:05 ` Frank Li
2024-10-08 17:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwVn7witZ3Bt8ktu@black.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Frank.li@nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).