From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3577423B634; Thu, 26 Jun 2025 22:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750975621; cv=none; b=dUh0Of/lIDKKpN8fLvmQHBVO+ZBSBr06/pCLjXsJCYukLWO3/qnF5vFX0ALiP+8Fc/OR6k7Pr7tgG3qq4DxSyNx0BQ4qNqb6idLWlUb3eR9VQJIJxK/+55rc9dy98XzjPX9ipSoioXe9rn26zFGHDTul9sapZWzbndhpTgBA1Gs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750975621; c=relaxed/simple; bh=jcDmlXlPtyzdOIJ5SLX8GV0/QYmp1r6I5Va/AUcO+BE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PoPm56mk3Z/Tm7NN0iLkZnoUFZ9mJ/bYCeoR8FAvT5m1vyq/bTIRMse8dXHbFGcHP1tQIkdPsoM3RUIagEafuA/FDaRXKcDxtY6Xc63ZQ5fEKTA5VlC9WOxC5KSVI9SR0LkwfF+0BX1H5lvQ03DRKJh+L5nA+dH6ubX6z/w55xE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nknxJ0lE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nknxJ0lE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91B98C4CEEB; Thu, 26 Jun 2025 22:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750975620; bh=jcDmlXlPtyzdOIJ5SLX8GV0/QYmp1r6I5Va/AUcO+BE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nknxJ0lE3sEgU97T8OXZUN5dotQCkRISDueEJ5SV/Qb6IjJB5ltBwRfyHvuBl9znB zLLjgrnJldnWtt37Qb09bTMFZDAZ/NB+EaUJa7hDDTxeTynZN6C8UzIoJ0cUxawG/H XBpWKGo6rTUiFU03jCR/1NQhyRL5nmVQscG/cM/Nr+6gOB5SH8ZEowXf7OONHm8e2t YXJ/wY6cDGmPE4BYg6VbqhB4XG40eDATJSjwpIzSmBif5vkq8osFKk2Sw9TKro/HJx d/JuqgzciX6bLviW5mnsB6cBCdhG1cl0bEH0i3Ei7YT5yWnCqOoHKdWDKQxcOll3Ac MgC4GMKgEICWg== Date: Thu, 26 Jun 2025 15:06:59 -0700 From: Vinod Koul To: Devendra K Verma Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, mani@kernel.org Subject: Re: [RESEND PATCH] dmaengine: dw-edma: Add Simple Mode Support Message-ID: References: <20250623061733.1864392-1-devverma@amd.com> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250623061733.1864392-1-devverma@amd.com> On 23-06-25, 11:47, Devendra K Verma wrote: > The HDMA IP supports the simple mode (non-linked list). > In this mode the channel registers are configured to initiate > a single DMA data transfer. The channel can be configured in > simple mode via peripheral param of dma_slave_config param. > > Signed-off-by: Devendra K Verma > --- > drivers/dma/dw-edma/dw-edma-core.c | 10 +++++ > drivers/dma/dw-edma/dw-edma-core.h | 2 + > drivers/dma/dw-edma/dw-hdma-v0-core.c | 53 ++++++++++++++++++++++++++- > include/linux/dma/edma.h | 8 ++++ > 4 files changed, 72 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c > index c2b88cc99e5d..4dafd6554277 100644 > --- a/drivers/dma/dw-edma/dw-edma-core.c > +++ b/drivers/dma/dw-edma/dw-edma-core.c > @@ -235,9 +235,19 @@ static int dw_edma_device_config(struct dma_chan *dchan, > struct dma_slave_config *config) > { > struct dw_edma_chan *chan = dchan2dw_edma_chan(dchan); > + struct dw_edma_peripheral_config *pconfig = config->peripheral_config; > + unsigned long flags; > + > + if (WARN_ON(config->peripheral_config && > + config->peripheral_size != sizeof(*pconfig))) > + return -EINVAL; > > + spin_lock_irqsave(&chan->vc.lock, flags); > memcpy(&chan->config, config, sizeof(*config)); > + > + chan->non_ll_en = pconfig ? pconfig->non_ll_en : false; > chan->configured = true; > + spin_unlock_irqrestore(&chan->vc.lock, flags); > > return 0; > } > diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h > index 71894b9e0b15..c0266976aa22 100644 > --- a/drivers/dma/dw-edma/dw-edma-core.h > +++ b/drivers/dma/dw-edma/dw-edma-core.h > @@ -86,6 +86,8 @@ struct dw_edma_chan { > u8 configured; > > struct dma_slave_config config; > + > + bool non_ll_en; why do you need this? What is the decision to use non ll vs ll one? > }; > > struct dw_edma_irq { > diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c > index e3f8db4fe909..3237c807a18e 100644 > --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c > +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c > @@ -225,7 +225,7 @@ static void dw_hdma_v0_sync_ll_data(struct dw_edma_chunk *chunk) > readl(chunk->ll_region.vaddr.io); > } > > -static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) > +static void dw_hdma_v0_ll_start(struct dw_edma_chunk *chunk, bool first) > { > struct dw_edma_chan *chan = chunk->chan; > struct dw_edma *dw = chan->dw; > @@ -263,6 +263,57 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) > SET_CH_32(dw, chan->dir, chan->id, doorbell, HDMA_V0_DOORBELL_START); > } > > +static void dw_hdma_v0_non_ll_start(struct dw_edma_chunk *chunk) > +{ > + struct dw_edma_chan *chan = chunk->chan; > + struct dw_edma *dw = chan->dw; > + struct dw_edma_burst *child; > + u32 val; > + > + list_for_each_entry(child, &chunk->burst->list, list) { > + SET_CH_32(dw, chan->dir, chan->id, ch_en, BIT(0)); > + > + /* Source address */ > + SET_CH_32(dw, chan->dir, chan->id, sar.lsb, lower_32_bits(child->sar)); > + SET_CH_32(dw, chan->dir, chan->id, sar.msb, upper_32_bits(child->sar)); > + > + /* Destination address */ > + SET_CH_32(dw, chan->dir, chan->id, dar.lsb, lower_32_bits(child->dar)); > + SET_CH_32(dw, chan->dir, chan->id, dar.msb, upper_32_bits(child->dar)); > + > + /* Transfer size */ > + SET_CH_32(dw, chan->dir, chan->id, transfer_size, child->sz); > + > + /* Interrupt setup */ > + val = GET_CH_32(dw, chan->dir, chan->id, int_setup) | > + HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK | > + HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; > + > + if (!(dw->chip->flags & DW_EDMA_CHIP_LOCAL)) > + val |= HDMA_V0_REMOTE_STOP_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN; > + > + SET_CH_32(dw, chan->dir, chan->id, int_setup, val); > + > + /* Channel control setup */ > + val = GET_CH_32(dw, chan->dir, chan->id, control1); > + val &= ~HDMA_V0_LINKLIST_EN; > + SET_CH_32(dw, chan->dir, chan->id, control1, val); > + > + /* Ring the doorbell */ > + SET_CH_32(dw, chan->dir, chan->id, doorbell, HDMA_V0_DOORBELL_START); > + } > +} > + > +static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) > +{ > + struct dw_edma_chan *chan = chunk->chan; > + > + if (!chan->non_ll_en) > + dw_hdma_v0_ll_start(chunk, first); > + else > + dw_hdma_v0_non_ll_start(chunk); > +} > + > static void dw_hdma_v0_core_ch_config(struct dw_edma_chan *chan) > { > struct dw_edma *dw = chan->dw; > diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h > index 3080747689f6..82d808013a66 100644 > --- a/include/linux/dma/edma.h > +++ b/include/linux/dma/edma.h > @@ -101,6 +101,14 @@ struct dw_edma_chip { > struct dw_edma *dw; > }; > > +/** > + * struct dw_edma_peripheral_config - peripheral spicific configurations > + * @non_ll_en: enable non-linked list mode of operations > + */ > +struct dw_edma_peripheral_config { > + bool non_ll_en; > +}; > + > /* Export to the platform drivers */ > #if IS_REACHABLE(CONFIG_DW_EDMA) > int dw_edma_probe(struct dw_edma_chip *chip); > -- > 2.43.0 -- ~Vinod