DMA Engine development
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: dmaengine@vger.kernel.org, Kelvin Cao <kelvin.cao@microchip.com>,
	George Ge <George.Ge@microchip.com>,
	Christoph Hellwig <hch@infradead.org>,
	Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/3] dmaengine: switchtec-dma: Implement hardware initialization and cleanup
Date: Sat, 22 Nov 2025 14:23:16 +0530	[thread overview]
Message-ID: <aSF5_Go4bddAbx38@vaman> (raw)
In-Reply-To: <20251014192239.4770-3-logang@deltatee.com>

On 14-10-25, 13:22, Logan Gunthorpe wrote:
> From: Kelvin Cao <kelvin.cao@microchip.com>
> 
> Initialize the hardware and create the dma channel queues.

This looks mostly okay. Any reason why virt-dma is not used in this
driver?

-- 
~Vinod

  reply	other threads:[~2025-11-22  8:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14 19:22 [PATCH 0/3] Switchtec Switch DMA Engine Driver Logan Gunthorpe
2025-10-14 19:22 ` [PATCH 1/3] dmaengine: switchtec-dma: Introduce Switchtec DMA engine skeleton Logan Gunthorpe
2025-10-14 19:22 ` [PATCH 2/3] dmaengine: switchtec-dma: Implement hardware initialization and cleanup Logan Gunthorpe
2025-11-22  8:53   ` Vinod Koul [this message]
2025-11-24 16:58     ` Logan Gunthorpe
2025-10-14 19:22 ` [PATCH 3/3] dmaengine: switchtec-dma: Implement descriptor submission Logan Gunthorpe
2025-11-04 16:51 ` [PATCH 0/3] Switchtec Switch DMA Engine Driver Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSF5_Go4bddAbx38@vaman \
    --to=vkoul@kernel.org \
    --cc=George.Ge@microchip.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dmaengine@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=kelvin.cao@microchip.com \
    --cc=logang@deltatee.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox