From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11010037.outbound.protection.outlook.com [52.101.229.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 185A0199EAD; Thu, 28 May 2026 13:46:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.37 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779975969; cv=fail; b=ijE0Rll9D9iKUiwTtOYIBFMr9OnPuEzrenT6YV8SIBghZby1Cm6keVIR90jNxiqXvcBfVYc7oT6BiX+IHx3TjMq1w9e4S01Yr09+W15Buyq5AbAw39j+HtiFHqbrnPVv5p0n1rZ2x8wr5yYoncgDVJU0OUpNBoDxld3I3+RgRIQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779975969; c=relaxed/simple; bh=FsNsmH1/6MkmJMJD8dBuyWzjlJulj8W+u0igBzNCg50=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=Kobixbm5kFCJ+JFRTY33dm/XXsyRfhKfb8LtZ0oCRMwIHCaTuhyuvvYgS7vRdxDj6NzcI328jmyQCTrez2xDoP9mKnUtu6eOo+EfdcxVtpW/5AOgQyFderxrtjlVsGT340NV/PdEDAVeNwRWB35TmV+Aq5zV4IclAdEnZwvXanE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=lZRgj+KO; arc=fail smtp.client-ip=52.101.229.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="lZRgj+KO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HKAPKHSOlxnHptNKnzhfSq5rag6Ao+BRqwbeFdrVfN7IY4+SBjZmTUZlRu8eCmCPL71pLHD18J89By62uSQ8zZ6an1qzI5M1/mTMSSzkIOhdv9F/z2tYufBV44QX/XaDgmpZwwo8Ah6vkkxZ7OYb7jKFCqXiaElD1iJ8AuKVoHHY1rYF6VmWUcGb6UV6ShIW8ypom0wW2lkruInnQ8uW99ag4pq9u/0QThAgg+S9kPcjLe1E5vJeah2r4YT4zsUaQ5pTOKS7xHrca6g7fffujOIWteI64vZjoCe65iuMMZ19zT6C+vvNkk+WoV+vakfy9HoUo3PYbCF8XaN4DhJXjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j/4Fk0C0Up4R6IHVCFUPEmCzgQ/DGqIDiaScpRJl4JM=; b=Rw0QEACmU7sk3HMvBVT6j55MOMfPDYgQN7DBn7v28R7V+vgDoeICLcKFSVBKsEeIqCv+gupq/L2s3PScUXVw0YfKdPpS7I5qMY6dbpO9L71VS+Mu8tzLz0AUl8mDJHkiZ7cTquP95RK9/A/lJOYtmtR3lNYcKB9XocsmNUqnWwFSopkDKVtlROn05Hr1fuO5CVKkiTTF/yJDFiPIcCpzIbxKOcDOP6C1g38ADax8FN3yf8KeJIbtU+Si0dRThV2MxCtgcrXe3GQ0g/tgyk5WXuLBRYTKG+Tw2sk68z/FjbLl87o9HFfFBb1dMazHrKwcMv57mdmlfyF3stDx+1RInQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j/4Fk0C0Up4R6IHVCFUPEmCzgQ/DGqIDiaScpRJl4JM=; b=lZRgj+KOr27RccCDiRTiFmYx0KsOjh9T3VH9zLrvWXpSYoT3uAMGBdkek1ZDPNYtlRFQmyH1OzmrPngI/jare3kUakFGwIVIB7cONtyApjjRnnAAqeBEA2V78e+8giJ7+UNdLy9B5fVjGz7y22EakeNiLVlR64+2H8PCMozpDjQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) by OSRPR01MB11420.jpnprd01.prod.outlook.com (2603:1096:604:234::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.13; Thu, 28 May 2026 13:46:05 +0000 Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8]) by TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8%5]) with mapi id 15.21.0071.011; Thu, 28 May 2026 13:46:05 +0000 Date: Thu, 28 May 2026 15:45:52 +0200 From: Tommaso Merciai To: Claudiu Beznea Cc: vkoul@kernel.org, Frank.Li@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, p.zabel@pengutronix.de, geert+renesas@glider.be, kuninori.morimoto.gx@renesas.com, long.luu.ur@renesas.com, claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea , Frank Li , John Madieu Subject: Re: [PATCH v6 03/18] dmaengine: sh: rz-dmac: Use list_first_entry_or_null() Message-ID: References: <20260526084710.3491480-1-claudiu.beznea@kernel.org> <20260526084710.3491480-4-claudiu.beznea@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260526084710.3491480-4-claudiu.beznea@kernel.org> X-ClientProxiedBy: FR0P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::12) To TY3PR01MB11948.jpnprd01.prod.outlook.com (2603:1096:400:409::5) Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB11947:EE_|OSRPR01MB11420:EE_ X-MS-Office365-Filtering-Correlation-Id: 429b76fa-240d-4895-475a-08debcbf76f0 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|52116014|1800799024|38350700014|18002099003|22082099003|4143699003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: oASIS9WTq8A5tJT3ENiqLuKeiD8El6DV3TIoE5WDXj/5FVl1CpqWKBYzjDD4L+ZKAfNSVPv3P/Ay0dMG2Vka+EdzBvLIjEMAT8zTGdYSlHB9c5hgw26pB1mmrurd102VBcZ3QeCX514on+Gu8bO+JKI271yfq3jUrGbPdHjBI/TIq+HLDSMTKYTxumMSeKwDIM/z6AjV+1QP+SXt8G8NPCa+nEwpXa/p4gfC2OEMlbCMhtrkMvDgYE2c7fALGNBrvcsxG6FvRocnaKr1OTQCVg1IPWEJ0q48C0xu5Ri6XTNAW/RhD5783AfKLqMnXLrLooB1lKccYqQXYpoVOAvSzgl8JudU9a6LkO9LrNHHfQvLpX2Bdw8ybDP6ylBR2orkbYn8gJzloNJhYkvbDCTLCOhE5CA12PspKbVkpibO3xSRpiF3zM3vDLLudwFoDwbsyfNiPKVenu4kJtX2GIueS3iR7YzvW2Duj28R0KRtxYYKDKdnIzDDu2+zzhEG4Uy0K+1UuU0nMzXDm2haD6nx/MXhwjGCvL5XhXNY/NAqAj16esM3jO4AV0kMeXWWeQF1svafuEIZyfFN/oYXm5zqWoAH8uyceP/KziVcKm8nQPEqiVK8YG0CQKYY2JOdAIz90cG+Yw01RE6NkXgvP7S0bt+F0KMtnOrbzW1RBzfPLUYfec+55e1NksTHYBtRA6hpFadm86nFSzEnE3XNExdl4P7hbsLa/P+mjg4oBwlqBEs8GWeAgtQfWMMO8YCrUvml X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11947.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(52116014)(1800799024)(38350700014)(18002099003)(22082099003)(4143699003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E10BFHQi+f1vAMWJ8P6Mh/rhMYmG+pwgRYNvZF5mVBd4lKB0zFGUkzOxzBac?= =?us-ascii?Q?CuX2vkM1j7ui2C1UKSI35JVO/kMZ+8OjbTaHa1uVPsFKqjPXPzEDjD/T5LEQ?= =?us-ascii?Q?W6DkpH8N5mcumDkuMK3lnBjUfgs+H9cV43IzAjzHG8hr53gHt1ZVaXa27+ID?= =?us-ascii?Q?9Ur6U1SWko0fbeXn6253h7GdMs6YWYqPAuQA2m4mKW9F8gCcQq2u+jPJY53M?= =?us-ascii?Q?PqUPSu7Icda6j1PVnW5EGGX8NIvgywHUSUEh1fbWeuBE6XgZMom242V0ND/l?= =?us-ascii?Q?e9ynAsgzKnf/wlZt1vIh5CycIRVw1Z/6RTJzevVDXbX6soLWZJIB2DFQQn+t?= =?us-ascii?Q?ef146TJajFGeI2Z65F+AbN4AaOOudO5A65OQ2od+YPZgzgGardrZCckONHL5?= =?us-ascii?Q?P8lM6KUB7SwpH/NftUCLN+ksy0uXnpwgXL8Cu63KtsVis8fcM1YOcjDS737T?= =?us-ascii?Q?tO3b+vSeQnGIT25irFrSHX2V85dTFH4za/DS0pWIyRdB2aYelKX11TmMXrWS?= =?us-ascii?Q?vT3/2WfjGX8O2h4luDDbuM3vh1ECq8zmR5Tu5q1fAEdZFmxNoto73JSrYBi4?= =?us-ascii?Q?W2BQyoX/Tzk6JkYOhu2oTxwH8RfNBcNH4kHFRHuci9Qhh9pQmGqYCyfOAkM1?= =?us-ascii?Q?VkByZRZ9pBaaq35Wknr7x+mZl4fPgApfoEqCMFYd6ZGPbd3TQSTg/jffR/UB?= =?us-ascii?Q?2l9bZWY++v+K8wr+JUzX3XzFz7/qDZukncdpgf4omsya9MxyLrBsUHrFnut/?= =?us-ascii?Q?LCPjcrBuYh8bHDp/BvW/fOj/zJg+r0hndONQACY7nPogdBepVHewyklZe+4X?= =?us-ascii?Q?1hNq1Buq45iVFxepCjy1nI5gNxt/kUcHkOcPAbxa5tGG1TtPvyon1vmkBeN8?= =?us-ascii?Q?XqVD4WkVMucjN8EBWBBs7zAnrlKM5ie5PEhchellet4f6YAvGBW/MBn4gHXQ?= =?us-ascii?Q?XmMhABtiOLxqbORuv0a220CeNQ1KMi9lRKcp9lIgrt2WUXElpTA7gjHDI1hh?= =?us-ascii?Q?2hnXoUAaffoVqLsMmuAN076zUwH+5ZqIF0eXQ7vkHux8LJQ/Dra7RvWlhDYi?= =?us-ascii?Q?NZdDVN1YhnmqqcHOCevCQrQKXagnU29G4fxYwUgd94/Ol9pGuzyEaj8gOTqF?= =?us-ascii?Q?zOG3glmFt8MlvMkUiBHBz5Pe+tzOaNkn3+V0Y6gEtucn1ns6WI8nyIowSPi+?= =?us-ascii?Q?Vsg01Uxwx8Ib7YngQd/Ih2/dueynrT5Q0Kdm+2IPBWqSrUjMyUDo29YQimpY?= =?us-ascii?Q?/YZ80AknSpkxIGk6HyyaE+eK1V/maC8owi9UpSM/kpNr3AKxjyLdCBXZPIqq?= =?us-ascii?Q?DHOIZuFq2xXBg1TrehvXvkr7pX8vT5pO/Lc4Vb73lT29Sa6ajHTDSW2D8wy5?= =?us-ascii?Q?S4PsUIpn5ZaIEsZGkQNFlXPYDtZphPK1TRXO2ThKyYv+uqzPBT3Yo5SFBcmG?= =?us-ascii?Q?NPNb2MUGLE6v213iZ5vb1Viw7cxN7r8KWrA623RNhE+PiI5+JGDQZPu6ck7S?= =?us-ascii?Q?b2Dwhf7MtmRzjnT1yYOIXDXSbdOmLHljnLCp3+ZvuoIGUqG8neOz2cMDlg7X?= =?us-ascii?Q?tDqK8FJjsBnGTl0gnom/UlLpjZEUTL1Wpf/Fx4ezDvzc0CP14GkiPmlDXpqU?= =?us-ascii?Q?UfsdOtEca0MlxJK0uTqirkXMi3KRrjY79P+wFnpERy3TUuZanX2jDKAKqFYE?= =?us-ascii?Q?EiaZhoC8HTzS8uSYSCcFfOBU0d/C8gL30GGrM37s9S/DWI88DsFeHmGBdHBu?= =?us-ascii?Q?had8JwVDYU3aaq6GSPqcbOx0tJQiNMKAfdyKcF+B2QIHlU+vgVPT?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 429b76fa-240d-4895-475a-08debcbf76f0 X-MS-Exchange-CrossTenant-AuthSource: TY3PR01MB11948.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2026 13:46:05.7864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8b4//0K3RZ7u65BUop17NGKePG4l9HrJiKevi3uG41kVbffWmLY0vAb4cQi8Wgh0VQXO3L76pmNxz6Uylm2FGseEI87aSXWGqNeq31kufui/o9m0YvStdPRY9RU4MzcL X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSRPR01MB11420 On Tue, May 26, 2026 at 11:46:55AM +0300, Claudiu Beznea wrote: > From: Claudiu Beznea > > Use list_first_entry_or_null() instead of open-coding it with a > list_empty() check and list_first_entry(). This simplifies the code. > Tested-by: Tommaso Merciai > Reviewed-by: Frank Li > Tested-by: John Madieu > Signed-off-by: Claudiu Beznea > --- > > Changes in v6: > - collected tags > > Changes in v5: > - none > > Changes in v4: > - none > > Changes in v3: > - none, this patch is new > > drivers/dma/sh/rz-dmac.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c > index 6d80cb668957..1717b407ab9e 100644 > --- a/drivers/dma/sh/rz-dmac.c > +++ b/drivers/dma/sh/rz-dmac.c > @@ -503,11 +503,10 @@ rz_dmac_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src, > __func__, channel->index, &src, &dest, len); > > scoped_guard(spinlock_irqsave, &channel->vc.lock) { > - if (list_empty(&channel->ld_free)) > + desc = list_first_entry_or_null(&channel->ld_free, struct rz_dmac_desc, node); > + if (!desc) > return NULL; > > - desc = list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); > - > desc->type = RZ_DMAC_DESC_MEMCPY; > desc->src = src; > desc->dest = dest; > @@ -533,11 +532,10 @@ rz_dmac_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, > int i = 0; > > scoped_guard(spinlock_irqsave, &channel->vc.lock) { > - if (list_empty(&channel->ld_free)) > + desc = list_first_entry_or_null(&channel->ld_free, struct rz_dmac_desc, node); > + if (!desc) > return NULL; > > - desc = list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); > - > for_each_sg(sgl, sg, sg_len, i) > dma_length += sg_dma_len(sg); > > -- > 2.43.0 >