From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id F4114331EC2;
	Tue,  9 Jun 2026 19:55:08 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1781034909; cv=none; b=CAc4k+5D3W1Dwfx6VWs8f6n/GpmJGcqeCOB4oLIWoovtiYOwb8rzIRlulU8boLkJuiKlBTk0II0ys1weXBCaNVJZUKjyQyL+41f66rVRc+aNSjGUJBelemqw334duN0REQyb/08bfKtH1Q/KEsQHnjRlFlJlCEO2dSpCECpgkXE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1781034909; c=relaxed/simple;
	bh=m/z3i0fbsaBqvVw0Ox8WMFd84iLnz92YliJ3Z5hIfZc=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=hI23nQ/mEDM3vyzZR2mCZEfBrXwjDSo+sYBwd3rRvZN5LmZ+wccOriM3/xxlcEsieF4GSRpk3XKWeDuq4ci4X81SG1gAC4OCcw/IR5GDAYw35r59058C26QuMQOnxr/d+jEqqZXHjbBMEdR43WrpVa2lLA7Qx72qpB2kJAI35gU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gluLioSu; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gluLioSu"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CC1A1F00898;
	Tue,  9 Jun 2026 19:55:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1781034908;
	bh=81tJvxqzlK7/8ZZbvXQTCyj7rNGbXzYNhmDalpdbN0c=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=gluLioSuO+3CDw4ZCW21iDltj2IglNrYooiGNaW5P3+xzpaHTzh+rJTajcWKrI7A3
	 gX3fV2l3zHB2ZwjKHGqGkU9eBxmUjHG+l2iZDfzYCX4B07NtoWEeI4Jfz54VdvZU9h
	 N7TKVuq8JgokX2H9klqsPzdN33b6emhP8NJBPOCifs79wHVYV6RiQ1up7FFopkFFaT
	 dJAWw1sAZ76lI8GmF8Te554qN8d6wZARkTrjZu5PVsKqqWLHsoC2nFx0G0I+YBFLEx
	 QI0GkNX4wwrJcCDmjJ7toLkcMx8CHmdVpn2Csjj5OlW5+1zyEcQRIg8YF/Up5XwP1A
	 eaoX00X9gqMCQ==
Date: Tue, 9 Jun 2026 13:55:05 -0600
From: Tycho Andersen <tycho@kernel.org>
To: nathan.lynch@amd.com
Cc: Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>, 
	Bjorn Helgaas <bhelgaas@google.com>, David Rientjes <rientjes@google.com>, John.Kariuki@amd.com, 
	Jonathan Cameron <jic23@kernel.org>, Kinsey Ho <kinseyho@google.com>, 
	Mario Limonciello <mario.limonciello@amd.com>, PradeepVineshReddy.Kodamati@amd.com, 
	Shivank Garg <shivankg@amd.com>, Stephen Bates <Stephen.Bates@amd.com>, 
	Wei Huang <wei.huang2@amd.com>, Wei Xu <weixugc@google.com>, dmaengine@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 09/23] dmaengine: sdxi: Start functions on probe, stop
 on remove
Message-ID: <aihu-faXvEv56K3v@tycho.pizza>
References: <20260605-sdxi-base-v3-0-4d38ca2bdffe@amd.com>
 <20260605-sdxi-base-v3-9-4d38ca2bdffe@amd.com>
Precedence: bulk
X-Mailing-List: dmaengine@vger.kernel.org
List-Id: <dmaengine.vger.kernel.org>
List-Subscribe: <mailto:dmaengine+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:dmaengine+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260605-sdxi-base-v3-9-4d38ca2bdffe@amd.com>

On Fri, Jun 05, 2026 at 07:02:12PM -0500, Nathan Lynch via B4 Relay wrote:
> +static void sdxi_pci_remove(struct pci_dev *pdev)
> +{
> +	pci_disable_sriov(pdev);

I think this should be in patch 3, since that is what introduces
.sriov_configure(), and then this patch adds the additional call to
sdxi_unregister().

Thanks,

Tycho

> +	sdxi_unregister(&pdev->dev);
> +}
> +
>  static const struct pci_device_id sdxi_id_table[] = {
>  	{ PCI_DEVICE_CLASS(PCI_CLASS_ACCELERATOR_SDXI, 0xffffff) },
>  	{ }
> @@ -73,6 +79,7 @@ static struct pci_driver sdxi_driver = {
>  	.name = "sdxi",
>  	.id_table = sdxi_id_table,
>  	.probe = sdxi_pci_probe,
> +	.remove = sdxi_pci_remove,
>  	.sriov_configure = pci_sriov_configure_simple,
>  };