From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 532F5282F36; Thu, 11 Jun 2026 05:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781155018; cv=none; b=s8+zDoVwEeZqJU4WEFofEKvdOad9yj2xKIR3hLj3fQfnNny5RyaXRWbPk/u/uxxdFLGviD7xA7zzCBaGY8+nze967qBlnegt8MLb/ScldLUBJNHCFWUtUFI2TvyH7EuHR3OSbYpvQZAdtQz+Hccc2TTycPjDbiUg3CIB51hFUZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781155018; c=relaxed/simple; bh=UxU8NW1oxglHhvrpRbd3iv5XCWknDkPJGquhC55/Lk0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jaYt35wRNcWrNW6Owo+hTWWbzz1J0lSsgi1rN1dVxRVYfHNsXscgZBtazuEdXVDhsCueGfdTuJG/9sp3mCUbE9t28HoHQ9IJ8D/HyUgnDIaAjI2wia556gNiqzEpvtQulMLfcMMdiwmF9TEsY8Q6/hD4CR5CY7MqktquuE1rYro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kjcr8NEa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kjcr8NEa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F7DE1F00893; Thu, 11 Jun 2026 05:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781155016; bh=/nLRK4QUMz1r3MO+y0IocMo3n6pFJgB1ZjfRsbA+0cI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=kjcr8NEa0cSPi+PCTHlPQDG3xORmWbo/EoQT5aqWdp9jb0IIV9ppl5jLw/DKCZgCa bAiRaQwjR39mSfsmq3QixrX111ZIFce0d9ZL4ZRuWfdkLNAfwcGc6o1RP3rDZB3rPN B3u0Wa+Cd7+ylkMMBdrdRriFG9kWPswvW4Qh5GDGtwaz6mXyMuiGNKQk8GJUiI3zpr pmfJuRu1cgh0I1Mx0Sbq9cn32kNI1DOT1KwNGUTWZ7W0EsjcV9UcTe8dKRrL6tCEuQ dHzeqp9A/Vk6qXXR1a8dove9JfrQVq8pHYCnmZPJUJTgBcUvMlDct+segYJRJoqO7I GJy8FIER1H0NQ== Date: Thu, 11 Jun 2026 10:46:52 +0530 From: Vinod Koul To: Frank Li Cc: Rosen Penev , dmaengine@vger.kernel.org, Frank Li , open list Subject: Re: [PATCH 3/3] dma: mv_xor: use devm for dma pool and irq Message-ID: References: <20260610065737.118211-1-rosenp@gmail.com> <20260610065737.118211-4-rosenp@gmail.com> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 10-06-26, 09:42, Frank Li wrote: > On Tue, Jun 09, 2026 at 11:57:37PM -0700, Rosen Penev wrote: > > Replace dma_alloc_wc with dmam_alloc_attrs and request_irq > > with devm_request_irq. This eliminates the need for > > manual cleanup of the dma pool and irq in both the channel > > remove function and the channel add error labels, removing > > the err_free_irq and err_free_dma labels entirely. > > > > Assisted-by: opencode:big-pickle > > Signed-off-by: Rosen Penev > > --- > > I already said many times, tag should dmaengine, not dma, all functional > need (), please respect reviewer's time. And the worst is that some patches frpm Rosen have dmaengine, some dma. That make me wonder how much thought has been given to these changes and might be just an exercise to push AI generated code into wild and see what sticks -- ~Vinod