Re: [PATCH v2 1/2] dmaengine: hsu: Drop unused platform driver data

["Uwe Kleine-König" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

Hello,

On Thu, Jun 11, 2026 at 08:11:05AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The commit message incorrectly states that it modifies struct pnp_device_id instead of struct pci_device_id.
> --
> 
> commit 5cb66572eea17e218716d84ce22cd0b73ee38c30
> Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> 
> dmaengine: hsu: Drop unused platform driver data
> 
> This patch drops the unused .driver_data assignments from the
> hsu_pci_id_table array. It only modifies the source code representation
> and does not affect the compiled output.
> 
> > The driver explicitly sets the .driver_data member of struct
> > pnp_device_id to zero without relying on that value. Drop these unused
> > assignments.
> 
> [Severity: Low]
> This isn't a bug, but the commit message states that the driver sets the
> member of struct pnp_device_id, while the patch actually modifies an
> array of struct pci_device_id in drivers/dma/hsu/pci.c. Should the
> commit message be updated to reference the correct struct?

Should I resent for that? If now, doing s/pnp/pci/ on the commit log
whan applying would be great.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]