From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011053.outbound.protection.outlook.com [52.101.70.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DF3335CBCB; Wed, 17 Jun 2026 20:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.53 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781729763; cv=fail; b=V8wlHL6hYWGWaNDSVdryAPbCYHQ6cHA1jpwFgZ35lyDRDtLpXflZ9orYA8ttsKZc6FrO8Blb4hM+PSHzdLc60ITWcseueah/AMdOzoHyXdkegN4BJVR+AEK1WFoa5KL7rWHZoBfw+KbpUH+UeEteIQJlQj/PlKWBiofktRjVac0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781729763; c=relaxed/simple; bh=wzVeWA6YQHfNG+QXSLch8WsXVNtWH7WPnLDOzJwZnSI=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=CAOhKAXjkPdohvuyemXvr43Zmec8yRBtJ8p7cO52LxN6itZTB4eG+Xoa1ihj8un9gxH5AoVrReB++R0kxqPd/jC5SSHR/HPuYcOsoDW23syQ6WulrSH+7dmy3TKGDnzX4i922MLSC0LjwB9hMSLfiDzdXtDWq4Ko017Shx0tofU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=HvnCA/2T; arc=fail smtp.client-ip=52.101.70.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="HvnCA/2T" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R/bAQRrXVYyUuPylKZ57G7BLjcllwIuHIGyy3jIfBMVdtrXvAS87DUIV8gl6XHeaoxFYQvdlmpMZnJESO5ZvMVK/Rai9beHcVGwGMGuNP+Fola4va/+lLbS/7fqyiZG0WRiyc0JKQAnAL2zC4Pe5R3bWfnkG6kMsv7LbQ2yvIqIa63pgHxkAamYVUNRXPAjEu87uxxM1Z5k0BV9i7b3Jcr2xerFPdDSRGjq93K4bKKjQxbRPErVVWIAt/dkjjDvj/g2wSkVnyBv7+fYPY9WjilRsZ2PIHiTmGtx9CTX8ZkjGFodD+QlCJDHVUWScwfdQTFGudABEEJkohgF1lQjhvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HDYrZEG4UBANLmNN40pYcs29L3FK7cCT2F0et4ZdubU=; b=NpHK8jNuFDgFzM/+YZvt85xlWq8nIhINwde/PgouyIo4aI0j9pWN6G+ab3P5etr+eBir8AhCaaI9eUWVRjIVIKlx20t7LaSyc/6dEqDCCdeA/HN61lOoKoVjgbGWrI0xyV0AfZN2Z9DYkqnY9KlyVo+WCQOsim5m2FdtKDIkuY+X+vCXjgnSAyUoVMmfAT5GivsSzg6Aa/35svxl9euV33X+0SmlZoRWcV26CHN1pMkQNslPmh+Gf6JH0chwQ37ljZ4I8+2jLm1Ze6uU7vjp/mA6hxjirIWsJ+//wAPE/FxfXKKqWS9p5bD08TY5xrlTmsize59/9OfzTwyi6WgayQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HDYrZEG4UBANLmNN40pYcs29L3FK7cCT2F0et4ZdubU=; b=HvnCA/2TgVaN6byfPjaitYp25JCkZuZD3fjlqNEoAqQot3/9ZrwF3DyAxJDT/idnBSwTwLEM6aFWmjDmVoP2wNe7MsliRaqJP5c1xbzl6WHFPT6USsG9TAQ8/FuY3GR1TdCwyx6l+K2jNAOiiVPlLVGyjW6nPFtAWfcqdVu2KRm+fJJ6kn7hZNSXsuvFmUBD0NDNhgp3qg33n/43oBGV1lt4fpZv4UEqYBXEb6rUc1kofdcmpWovQaSI5ViqbDuCLfm02sIkZJr6G6DspXJLjOfTVN/YRExpyxgfu0AaEJuhyS+SkDyJ87pVYKJQUa1zGUgA+JGMZkZCEaKndJVpgg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) by PAWPR04MB9888.eurprd04.prod.outlook.com (2603:10a6:102:385::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.13; Wed, 17 Jun 2026 20:55:56 +0000 Received: from GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c]) by GV2PR04MB11799.eurprd04.prod.outlook.com ([fe80::2146:83a2:5329:b7c%6]) with mapi id 15.21.0113.015; Wed, 17 Jun 2026 20:55:55 +0000 Date: Wed, 17 Jun 2026 16:55:48 -0400 From: Frank Li To: Hongling Zeng Cc: vkoul@kernel.org, Frank.Li@kernel.org, wens@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org, mripard@kernel.org, arnd@arndb.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, zhongling0719@126.com Subject: Re: [PATCH v3] dmaengine: sun6i-dma: Fix memory leak in sun6i_dma_terminate_all Message-ID: References: <20260617023411.574488-1-zenghongling@kylinos.cn> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260617023411.574488-1-zenghongling@kylinos.cn> X-ClientProxiedBy: PH0PR07CA0013.namprd07.prod.outlook.com (2603:10b6:510:5::18) To GV2PR04MB11799.eurprd04.prod.outlook.com (2603:10a6:150:2cf::9) Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11799:EE_|PAWPR04MB9888:EE_ X-MS-Office365-Filtering-Correlation-Id: d9489bd6-2915-4da6-9a1e-08deccb2d35e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|7416014|376014|23010399003|366016|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: c/ZommpGo+WdYtaE6m5TrgiD9+H2lGjP1aAZeWnhP1pzeYCayREeQTcnVGq+XXGgI0HowZgxZ7WKh31SxhabOu8E465cZFxee3dBfVZOyHUW1PUUk0oIWTsqFS6JSt7Rhw6VsGOY1p5sIFkqKFEdogRWZMGoe3XCA9Cywtnj4rmBlzs6884cfJcX96Geg1YzUtRXOgsM2Pu0Pk6kB0BQTof8njPL3MUyWroOQbBBReap/ZzbCvht5azKyurpyA21+iZL88KGPb7ZsD3g0FA5AP6XzR48O6HDo2lTaTMLgPv78Wt5Vvuu4SfpU67FyXnkU+NhCARq/zGZk0PLHjcZXgN/hTQZNrKhgS8WVdfgRLnHofHf+VVV2lDOOdo5YtAxXimUsDZH3ybnwdGrVhURLUtVPztCyamkMmgjId6xKyuyNxgMHxFUyIYvlwVyXX58lZnpEARsSBRhA5y2ktKOGMci6SkJz7cW5ho8YiZ+GRUaW02e7ziVNhs6tXawLi7w9OHa5hHjyeAmU7+UiyM1FA767mfCYfaTHXe1/nxqrzSnF1zO5NOVRXsonqygU3Oe694suXtGXeGlwjhI3qL9IfWJmR390njpw7wP91Mb7NHuDUT4C3pXQVfXkLjB5/mRlbWBMce8FACwsROR1s2s0ZVNSsv9YCiXRAHI3QiPuDFxo7nDX2Vdyo7m9RuU94ve X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR04MB11799.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(7416014)(376014)(23010399003)(366016)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/dmOLIdNk2l23iY2PCLleyHWsfoLCdI2HHj7UFgxgrHsGuiHFvFYEhuW9all?= =?us-ascii?Q?vouyPYD4dmQeY/AcWBL2yNnUCPre0dadw59JCUYBOWJLQkHCeKXylc8J5+3/?= =?us-ascii?Q?dfHG7t4FTSAR3ppZ4PaPAm0bghEGwDIc/rlyv2ltd6YMMC+IjtV3KdAPl+Nu?= =?us-ascii?Q?XMLuSsvVMzuy5HVsJSU8Ls4U0SCyf4oC0qxnIVg6qM1aOMj3HNdCGeVNcu5/?= =?us-ascii?Q?qFyxfBXlFGPlhvQd2g66+jZFnL8bS1iCL+oqzGQvHRFoRN6EMLFL0D09zGyF?= =?us-ascii?Q?UFjN/jz53ZJPhmfsptyH7pdH+4BTpIUNPr8ZIa4/hJ/e8OGCQnDU0u3Yo8kV?= =?us-ascii?Q?y7CMZnaZjdJ8ca5IhqfC4LjglU1pZ2sjzgdHksXTlQyqonndwSqo5PzP5v7Z?= =?us-ascii?Q?R7Z030HN4eDQD8KcdujX6yZGieNFgZr0zmLOW1cRtInZ8qkXMRplOchcEjb1?= =?us-ascii?Q?Zsq1BXSKefFLLfuUdqY9Od/sDzO40e5032KsmZmdyOoTiaF7wrzf0psYV1GK?= =?us-ascii?Q?p8Z9Ga+9d0Uh/GQz8UmDnnqTjeMrRkleXSPZx9SuuItyO6dPKaie70dnLXWx?= =?us-ascii?Q?PeHeGidVU8b/fbgcniLIz3Zp9Nway7Y/v/B2kC4SAAcMQMK0Qn02bf2Vgj+G?= =?us-ascii?Q?p/LC8ucFO7KL8Xej5WfPJkpirZ/dTevFK4JwsdspX4ZH++kSlgXBZfF+hJ3k?= =?us-ascii?Q?BQXnfR5XWbwMABJKXQNVDvVBnkbMgOsdDwuBNcYl/nvk/34zOiOGLphxWn2P?= =?us-ascii?Q?yeWyWBp2GSCMB/4DRulIPzEBQqbIOcf8ZIN9+/6+BhjLnnDhDsY+ZKX1ArG9?= =?us-ascii?Q?7w0KH6Q8AlKnBmQQsAzUvjyHOWtp3yqeab0G+EYN6419L4KDzgm+WjS320LH?= =?us-ascii?Q?ZR1+lKz16mNkVxPBEl7ok3rniQCkZfjWEsgdHifu3dk0HSp4sCTFuc7ip60f?= =?us-ascii?Q?9vTJ7qIczzXV2E/DgEEirBxvCjKZPIWEgeYIxOliFli0i1cmIK01mZC1AgYO?= =?us-ascii?Q?aL1S+TeJwlnxBelFvOyr5P/LMvAUOd/s4/pykFDKBE3Z+1xM94o8g3hFFsiu?= =?us-ascii?Q?F0dM+LDfijg/Y9qVV0ay1WFiWOUH/G8wjCQn/frcgI4ODCLV/ClLJ+tcAaWS?= =?us-ascii?Q?FqJICRQQPpFCFBKDXxYHwjpILNFpQSo0noDt1gzA/U8+W329seOHmeKcGM/Y?= =?us-ascii?Q?4aHK2Tbh/Y9Q3uklMFWMhWXUS6fl0yEERYxYv7RH6jXpUuAkHoxlUBRzFNxp?= =?us-ascii?Q?xseEukouyPZzHJk/ExE86hrmIOJfcXh1CYfJ5PuqF27uhiJ/2BFAZQz5y20H?= =?us-ascii?Q?KC3LYTQ7wwCu9wubJfBSB0MpiY7r5bOypRprEQI4zE7/BD/x/KIyl+fRj5L9?= =?us-ascii?Q?WShjk5leI9oWkJeZFiVayJgpJoRgBnbLl17IrXc1HjdR+2rveWHda5oCYNUa?= =?us-ascii?Q?9FnZeTlQaLNFd306gO0xf17NI0Bt6qLb+Aod5PFwpm1pE9Kt2nRpe+dESeGw?= =?us-ascii?Q?ZAOa8O7dnFFfI9VXRCJawB37oHQd4ELQ1wEH3QVjr+GF91+NGu2SIUe6dwa8?= =?us-ascii?Q?Nu5npeHWm4+Ts8iMwbPBRoFTVkdc1tZlEYqH8phzeFObz6LmIe0AE3+1Wl/A?= =?us-ascii?Q?APp49sBmmiD7j9cG6X6viB1HejrvtpijIcZhF8r2F1cutfJXD6BSxb959zm7?= =?us-ascii?Q?yK4mQZKYelv0jPwSk75Eg/qS29XEPQaOe9vmkGwSiq8TDMuRHRId5LDcYAAJ?= =?us-ascii?Q?TDZ+jhhT+YTOH8nlTe4k12pTmKOOC0HYbBiT+30TyHVs0U8QWYnc?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9489bd6-2915-4da6-9a1e-08deccb2d35e X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2026 20:55:55.7407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6MSQm/sQF88k81hEvTtuQ0OKrS2JO7I7+vXRCrG+9vIm6sKms5QxaCkLM342QxtmjaGXknbBuuqtQDl8wIBtsvGJDMb4iwwMlSX0USGKOSHXeNLBO2jdxgV9AxmmfW4W X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9888 On Wed, Jun 17, 2026 at 10:34:11AM +0800, Hongling Zeng wrote: > When terminating a non-cyclic DMA transfer, the active descriptor > is not properly reclaimed. The descriptor is removed from the > desc_issued list in sun6i_dma_start_desc(), but in > sun6i_dma_terminate_all(), only cyclic transfer descriptors are > added to the desc_completed list before cleanup. > > For non-cyclic transfers, pchan->desc is set to NULL without first > adding the descriptor back to a list that vchan_get_all_descriptors() > can collect. This causes the descriptor and its associated LLI chain > to be permanently leaked. > > Fix by ensuring both cyclic and non-cyclic active descriptors are > added to the desc_completed list before setting pchan->desc to NULL. Can you update this to match your change. Frank > > Fixes: 555859308723 ("dmaengine: sun6i: Add driver for the Allwinner A31 DMA controller") > Signed-off-by: Hongling Zeng > Acked-by: Jernej Skrabec > Suggested-by: Frank Li > > --- > Change in v2; > -Add pchan->desc != pchan->done check to prevent race condition > where completed descriptors could be double-added to desc_completed > list, causing list corruption > --- > Change in v3: > -Fix by using vchan_terminate_vdesc() as suggested by Frank Li > --- > drivers/dma/sun6i-dma.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > index 7a79f346250a..134ae840f176 100644 > --- a/drivers/dma/sun6i-dma.c > +++ b/drivers/dma/sun6i-dma.c > @@ -946,16 +946,13 @@ static int sun6i_dma_terminate_all(struct dma_chan *chan) > > spin_lock_irqsave(&vchan->vc.lock, flags); > > - if (vchan->cyclic) { > - vchan->cyclic = false; > - if (pchan && pchan->desc) { > - struct virt_dma_desc *vd = &pchan->desc->vd; > - struct virt_dma_chan *vc = &vchan->vc; > - > - list_add_tail(&vd->node, &vc->desc_completed); > - } > + if (pchan && pchan->desc && pchan->desc != pchan->done) { > + struct virt_dma_desc *vd = &pchan->desc->vd; > + > + vchan_terminate_vdesc(vd); > } > > + vchan->cyclic = false; > vchan_get_all_descriptors(&vchan->vc, &head); > > if (pchan) { > -- > 2.25.1 >